From: Jan Kara <jack@suse.cz>
To: Wang Shaoyan <stufever@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org,
Wang Shaoyan <wangshaoyan.pt@taobao.com>, Ted Tso <tytso@mit.edu>
Subject: Re: [PATCH] ext4: Set file system to read-only by I/O error threshold
Date: Mon, 20 Jun 2011 16:41:50 +0200 [thread overview]
Message-ID: <20110620144150.GE4810@quack.suse.cz> (raw)
In-Reply-To: <BANLkTikLrLPLgj3ykmqcZ_+KVQi85vrWAPSJHGX_hOV3nNL0sg@mail.gmail.com>
On Mon 20-06-11 22:12:48, Wang Shaoyan wrote:
> Thanks for your reply!
> 2011/6/20 Jan Kara <jack@suse.cz>:
>
> > Hum, if I understand your problem right, you should just mount the
> > filesystem with errors=remount-ro and you will get the behavior you need.
> > Or what is insufficient on that solution? Your patch surely provides more
> > flexibility but is that really needed?
> >
>
> 1.There are more than ten hard disks in each of our production
> machine, so it is not right for
> making the whole system panic, only based on one error in one harddisk.
> 2.There may be multiple tasks which access the same hard drive at the
> same time, so it is
> not ideal for changing the system to readonly, only based on one error
> in one task,
> while other task may be killed.
>
> That's why we have a relaxed restrictions, only when the error counter
> is grower than our
> threshold, we change fs to readonly or panic.
> When a system has a dozen hard drives, each hard drive is running
> several tasks on time,
> this feature is a real demand.
OK, but then your changelog is just misleading because your need for the
feature has nothing to do with different error behavior in ext4 nojournal
mode as far as I understand. So please describe your real needs in the
changelog as you described them above...
That being said I'm not sure such policies like when to remount fs
read-only belong to the kernel. It would seem more appropriate to me to
somehow propagate information about all IO errors to user space and have
some monitoring daemon (be it Hadoop or Nagios or whatever people use)
handle remounting the filesystem and marking the disk as offline. But
this is just my opinion and I don't want to block this feature. It's more
a suggestion for other people...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-06-20 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 12:08 [PATCH] ext4: Set file system to read-only by I/O error threshold stufever
2011-06-18 8:38 ` Lukas Czerner
2011-06-20 1:32 ` Wang Shaoyan
2011-06-21 14:48 ` Ted Ts'o
2011-06-21 15:58 ` Andreas Dilger
2011-06-20 13:36 ` Jan Kara
2011-06-20 14:12 ` Wang Shaoyan
2011-06-20 14:41 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620144150.GE4810@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stufever@gmail.com \
--cc=tytso@mit.edu \
--cc=wangshaoyan.pt@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).