From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: broken commit 25567a7b0fa98b390fd1ff0d4702b29c23a75bbb
Date: Fri, 8 Jul 2011 20:41:51 -0400 [thread overview]
Message-ID: <20110709004151.GL3331@thunk.org> (raw)
In-Reply-To: <7EF281B4-882D-4F81-AEF8-404D2C3C0B76@dilger.ca>
On Fri, Jul 08, 2011 at 06:07:14PM -0600, Andreas Dilger wrote:
> In my pull from e2fsprogs git "master" branch, it contains commit
> 25567a7b0fa98b390fd1ff0d4702b29c23a75bbb "support for bigalloc
> file systems with a blocksize of 1024" that deletes the initialization
> of the flexbg_size variable from lib/ext2fs/alloc_tables.c::flexbg_offset():
>
> - flexbg_size = 1 << fs->super->s_log_groups_per_flex;
> - flexbg = group / flexbg_size;
> + size = rem_grp * elem_size;
>
> but it continues to use flexbg_size later on in this function:
Yeah, sorry, fixed in the next branch. I thought I had advanced the
master branch enough to fix it, but I didn't advance it enough. Try a
pull now.
- Ted
prev parent reply other threads:[~2011-07-09 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 0:07 broken commit 25567a7b0fa98b390fd1ff0d4702b29c23a75bbb Andreas Dilger
2011-07-09 0:41 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110709004151.GL3331@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).