From: Ted Ts'o <tytso@mit.edu>
To: Dan Ehrenberg <dehrenberg@google.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH v2 2/2] ext4: Ignore a stripe width of 1
Date: Sun, 17 Jul 2011 21:21:05 -0400 [thread overview]
Message-ID: <20110718012105.GI2717@thunk.org> (raw)
In-Reply-To: <1310766115-4164-2-git-send-email-dehrenberg@google.com>
On Fri, Jul 15, 2011 at 02:41:55PM -0700, Dan Ehrenberg wrote:
> If the stripe width was set to 1, then this patch will ignore
> that stripe width and ext4 will act as if the stripe width
> were 0 with respect to optimizing allocations.
>
> Signed-off-by: Dan Ehrenberg <dehrenberg@google.com>
Applied to the ext4 tree. I did make one formatting change. Please
don't have blank lines between the if and else clauses, like this:
if (sbi->s_stripe && sbi->s_stripe <= sbi->s_blocks_per_group)
ret = sbi->s_stripe;
else if (stripe_width <= sbi->s_blocks_per_group)
ret = stripe_width;
else if (stride <= sbi->s_blocks_per_group)
ret = stride;
it wastes vertical whitespace and makes the control flow harder to
follow. Eliminate the blank lines, and it's easier to read, I think.
if (sbi->s_stripe && sbi->s_stripe <= sbi->s_blocks_per_group)
ret = sbi->s_stripe;
else if (stripe_width <= sbi->s_blocks_per_group)
ret = stripe_width;
else if (stride <= sbi->s_blocks_per_group)
ret = stride;
- Ted
next prev parent reply other threads:[~2011-07-18 1:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 21:41 [PATCH v2 1/2] ext4: Preallocation is a multiple of stripe size Dan Ehrenberg
2011-07-15 21:41 ` [PATCH v2 2/2] ext4: Ignore a stripe width of 1 Dan Ehrenberg
2011-07-15 21:47 ` Eric Sandeen
2011-07-18 1:21 ` Ted Ts'o [this message]
2011-07-18 1:13 ` [PATCH v2 1/2] ext4: Preallocation is a multiple of stripe size Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718012105.GI2717@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dehrenberg@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).