From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@redhat.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: hold page lock when checking mapping in ext4_page_mkwrite
Date: Mon, 18 Jul 2011 22:13:28 -0400 [thread overview]
Message-ID: <20110719021328.GA11918@infradead.org> (raw)
In-Reply-To: <1311004772-14675-1-git-send-email-josef@redhat.com>
On Mon, Jul 18, 2011 at 11:59:32AM -0400, Josef Bacik wrote:
> Pages can be evicted from cache outside of truncate, for example when
> invalidating pages after writing with O_DIRECT. The only proper way to check
> page->mapping is under the page lock, so fix ext4_page_mkwrite to do this.
> Thanks,
Josef, please check the ext4_page_mkwrite implementation in the vfs
tree, which is just a wrapper around the generic code and thus shouldn't
have this problem any more.
prev parent reply other threads:[~2011-07-19 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 15:59 [PATCH] ext4: hold page lock when checking mapping in ext4_page_mkwrite Josef Bacik
2011-07-19 2:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719021328.GA11918@infradead.org \
--to=hch@infradead.org \
--cc=josef@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).