* [PATCH XFSTESTS 1/3] configure.in: Declare a requirement for at least autoconf 2.50
@ 2011-07-21 23:52 Theodore Ts'o
2011-07-21 23:52 ` [PATCH XFSTESTS 2/3] Build without enabling DEBUG by default Theodore Ts'o
2011-07-21 23:52 ` [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm Theodore Ts'o
0 siblings, 2 replies; 4+ messages in thread
From: Theodore Ts'o @ 2011-07-21 23:52 UTC (permalink / raw)
To: Ext4 Developers List, xfs; +Cc: Theodore Ts'o
On Debian/Ubuntu systems, if autoconf version 2.13 is installed,
autoconf will try to automatically figure out whether autoconf 2.13 or
something more modern is required (since the autoconf maintainers,
curses be upon them, didn't bother to maintain compatibility between
autoconf 2.13 and 2.50). Unfortunately, the hueristics aren't
perfect, and although the configure.in file looks superficially like
it will be compatible with autoconf 2.13, it isn't. You will end up
with a number of very subtle compilation failures if you use autoconf
2.13.
So declare a requirement for autoconf 2.50 using AC_PREREQ(2.50).
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
configure.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure.in b/configure.in
index 45b7fd1..c697b4f 100644
--- a/configure.in
+++ b/configure.in
@@ -1,4 +1,5 @@
AC_INIT(src/xfsctl.c)
+AC_PREREQ(2.50)
AC_PACKAGE_GLOBALS(xfstests)
AC_PACKAGE_UTILITIES(xfstests)
--
1.7.4.1.22.gec8e1.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH XFSTESTS 2/3] Build without enabling DEBUG by default
2011-07-21 23:52 [PATCH XFSTESTS 1/3] configure.in: Declare a requirement for at least autoconf 2.50 Theodore Ts'o
@ 2011-07-21 23:52 ` Theodore Ts'o
2011-07-21 23:52 ` [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm Theodore Ts'o
1 sibling, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2011-07-21 23:52 UTC (permalink / raw)
To: Ext4 Developers List, xfs; +Cc: Theodore Ts'o
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
m4/package_globals.m4 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/m4/package_globals.m4 b/m4/package_globals.m4
index 72fbbb7..f468f50 100644
--- a/m4/package_globals.m4
+++ b/m4/package_globals.m4
@@ -15,7 +15,7 @@ AC_DEFUN([AC_PACKAGE_GLOBALS],
test -z "$BUILD_VERSION" || pkg_release="$BUILD_VERSION"
AC_SUBST(pkg_release)
- DEBUG=${DEBUG:-'-DDEBUG'} dnl -DNDEBUG
+ DEBUG=${DEBUG:-'-DNDEBUG'} dnl -DNDEBUG
debug_build="$DEBUG"
AC_SUBST(debug_build)
--
1.7.4.1.22.gec8e1.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm
2011-07-21 23:52 [PATCH XFSTESTS 1/3] configure.in: Declare a requirement for at least autoconf 2.50 Theodore Ts'o
2011-07-21 23:52 ` [PATCH XFSTESTS 2/3] Build without enabling DEBUG by default Theodore Ts'o
@ 2011-07-21 23:52 ` Theodore Ts'o
2011-07-22 14:29 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Theodore Ts'o @ 2011-07-21 23:52 UTC (permalink / raw)
To: Ext4 Developers List, xfs; +Cc: Theodore Ts'o
The value of $(LIBDM) may be a linker specification -ldm, and not a
file. So it's not OK to add this to the dependency, since make will
then complain that it doesn't know how to make the target -ldm.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
dmapi/src/common/cmd/Makefile | 2 +-
dmapi/src/sample_hsm/Makefile | 2 +-
dmapi/src/suite1/cmd/Makefile | 2 +-
dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c | 2 +-
dmapi/src/suite2/src/Makefile | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/dmapi/src/common/cmd/Makefile b/dmapi/src/common/cmd/Makefile
index 4b0e550..4525581 100644
--- a/dmapi/src/common/cmd/Makefile
+++ b/dmapi/src/common/cmd/Makefile
@@ -38,7 +38,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
diff --git a/dmapi/src/sample_hsm/Makefile b/dmapi/src/sample_hsm/Makefile
index 7a4ca8c..55df563 100644
--- a/dmapi/src/sample_hsm/Makefile
+++ b/dmapi/src/sample_hsm/Makefile
@@ -38,7 +38,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
diff --git a/dmapi/src/suite1/cmd/Makefile b/dmapi/src/suite1/cmd/Makefile
index 7e51763..05dbead 100644
--- a/dmapi/src/suite1/cmd/Makefile
+++ b/dmapi/src/suite1/cmd/Makefile
@@ -61,7 +61,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
diff --git a/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c b/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
index 6b4d0b6..c01dff0 100644
--- a/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
+++ b/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
@@ -69,7 +69,7 @@ xfsctl_punch_hole(
xfs_flock64_t flock;
int fd;
- if ((fd = open(path, O_RDWR|O_CREAT)) < 0) {
+ if ((fd = open(path, O_RDWR|O_CREAT, 0600)) < 0) {
perror(path);
exit(errno);
}
diff --git a/dmapi/src/suite2/src/Makefile b/dmapi/src/suite2/src/Makefile
index 91a0f00..c5cf6da 100644
--- a/dmapi/src/suite2/src/Makefile
+++ b/dmapi/src/suite2/src/Makefile
@@ -44,7 +44,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
--
1.7.4.1.22.gec8e1.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm
2011-07-21 23:52 ` [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm Theodore Ts'o
@ 2011-07-22 14:29 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2011-07-22 14:29 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List, xfs
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-22 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-21 23:52 [PATCH XFSTESTS 1/3] configure.in: Declare a requirement for at least autoconf 2.50 Theodore Ts'o
2011-07-21 23:52 ` [PATCH XFSTESTS 2/3] Build without enabling DEBUG by default Theodore Ts'o
2011-07-21 23:52 ` [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm Theodore Ts'o
2011-07-22 14:29 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).