From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Remove unnecessary ext4_get_group_info in ext4_mb_load_buddy.
Date: Sat, 23 Jul 2011 16:19:49 -0400 [thread overview]
Message-ID: <20110723201949.GA3469@thunk.org> (raw)
In-Reply-To: <1310915483-2906-1-git-send-email-tm@tao.ma>
On Sun, Jul 17, 2011 at 11:11:21PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> ext4_mb_load_buddy() calls ext4_get_group_info() for setting both
> "grp" and "e4b->bd_info", but it could do "e4b->bd_info = grp".
>
> Reported-by: Andreas Dilger <adilger@whamcloud.com>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Thanks, added to the ext4 tree.
- Ted
prev parent reply other threads:[~2011-07-23 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 15:11 [PATCH] ext4: Remove unnecessary ext4_get_group_info in ext4_mb_load_buddy Tao Ma
2011-07-17 15:11 ` [PATCH] ext4: Don't increase s_mb_buddies_generated in ext4_mb_release Tao Ma
2011-07-23 20:20 ` Ted Ts'o
2011-07-17 15:11 ` [PATCH] ext4: Remove ac_repeats from ext4_allocation_context Tao Ma
2011-07-23 20:20 ` Ted Ts'o
2011-07-23 20:19 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110723201949.GA3469@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).