* [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block
@ 2011-07-22 2:23 Robin Dong
2011-07-22 2:23 ` [PATCH 2/3] ext4: correct the debug message in ext4_ext_insert_extent Robin Dong
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Robin Dong @ 2011-07-22 2:23 UTC (permalink / raw)
To: linux-ext4; +Cc: Robin Dong
From: Robin Dong <sanbai@taobao.com>
The argument "inode" in function ext4_ext_next_allocated_block looks useless,
so clean it.
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
fs/ext4/extents.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index eb63c7b..3966839 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1447,8 +1447,7 @@ ext4_ext_next_allocated_block(struct ext4_ext_path *path)
* ext4_ext_next_leaf_block:
* returns first allocated block from next leaf or EXT_MAX_BLOCKS
*/
-static ext4_lblk_t ext4_ext_next_leaf_block(struct inode *inode,
- struct ext4_ext_path *path)
+static ext4_lblk_t ext4_ext_next_leaf_block(struct ext4_ext_path *path)
{
int depth;
@@ -1766,7 +1765,7 @@ repeat:
/* probably next leaf has space for us? */
fex = EXT_LAST_EXTENT(eh);
- next = ext4_ext_next_leaf_block(inode, path);
+ next = ext4_ext_next_leaf_block(path);
if (le32_to_cpu(newext->ee_block) > le32_to_cpu(fex->ee_block)
&& next != EXT_MAX_BLOCKS) {
ext_debug("next leaf block - %d\n", next);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] ext4: correct the debug message in ext4_ext_insert_extent
2011-07-22 2:23 [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block Robin Dong
@ 2011-07-22 2:23 ` Robin Dong
2011-07-24 1:55 ` Ted Ts'o
2011-07-22 2:23 ` [PATCH 3/3] ext4: correct comment for ext4_ext_check_cache Robin Dong
2011-07-24 1:55 ` [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block Ted Ts'o
2 siblings, 1 reply; 6+ messages in thread
From: Robin Dong @ 2011-07-22 2:23 UTC (permalink / raw)
To: linux-ext4; +Cc: Robin Dong
From: Robin Dong <sanbai@taobao.com>
The debug message in ext4_ext_insert_extent before moving extent
is incorrect (the "from xx to xx").
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
fs/ext4/extents.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 3966839..a4d6216 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1839,7 +1839,7 @@ has_space:
ext4_ext_pblock(newext),
ext4_ext_is_uninitialized(newext),
ext4_ext_get_actual_len(newext),
- nearex, len, nearex + 1, nearex + 2);
+ nearex, len, nearex, nearex + 1);
memmove(nearex + 1, nearex, len);
path[depth].p_ext = nearex;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] ext4: correct comment for ext4_ext_check_cache
2011-07-22 2:23 [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block Robin Dong
2011-07-22 2:23 ` [PATCH 2/3] ext4: correct the debug message in ext4_ext_insert_extent Robin Dong
@ 2011-07-22 2:23 ` Robin Dong
2011-07-24 1:55 ` Ted Ts'o
2011-07-24 1:55 ` [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block Ted Ts'o
2 siblings, 1 reply; 6+ messages in thread
From: Robin Dong @ 2011-07-22 2:23 UTC (permalink / raw)
To: linux-ext4; +Cc: Robin Dong
From: Robin Dong <sanbai@taobao.com>
The comment for ext4_ext_check_cache has a litte mistake.
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
fs/ext4/extents.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index a4d6216..cb8285d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2052,7 +2052,7 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
}
/*
- * ext4_ext_in_cache()
+ * ext4_ext_check_cache()
* Checks to see if the given block is in the cache.
* If it is, the cached extent is stored in the given
* cache extent pointer. If the cached extent is a hole,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block
2011-07-22 2:23 [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block Robin Dong
2011-07-22 2:23 ` [PATCH 2/3] ext4: correct the debug message in ext4_ext_insert_extent Robin Dong
2011-07-22 2:23 ` [PATCH 3/3] ext4: correct comment for ext4_ext_check_cache Robin Dong
@ 2011-07-24 1:55 ` Ted Ts'o
2 siblings, 0 replies; 6+ messages in thread
From: Ted Ts'o @ 2011-07-24 1:55 UTC (permalink / raw)
To: Robin Dong; +Cc: linux-ext4, Robin Dong
On Fri, Jul 22, 2011 at 10:23:39AM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
>
> The argument "inode" in function ext4_ext_next_allocated_block looks useless,
> so clean it.
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
Thanks, added to the ext4 tree.
- Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-24 1:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-22 2:23 [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block Robin Dong
2011-07-22 2:23 ` [PATCH 2/3] ext4: correct the debug message in ext4_ext_insert_extent Robin Dong
2011-07-24 1:55 ` Ted Ts'o
2011-07-22 2:23 ` [PATCH 3/3] ext4: correct comment for ext4_ext_check_cache Robin Dong
2011-07-24 1:55 ` Ted Ts'o
2011-07-24 1:55 ` [PATCH 1/3] ext4: remove unused argument in ext4_ext_next_leaf_block Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).