From: Christoph Hellwig <hch@infradead.org>
To: Ted Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: [PATCH XFSPROGS 2/3] Build without enabling DEBUG by default
Date: Tue, 26 Jul 2011 11:10:33 -0400 [thread overview]
Message-ID: <20110726151033.GA18311@infradead.org> (raw)
In-Reply-To: <20110723013214.GA22837@infradead.org>
On Fri, Jul 22, 2011 at 09:32:14PM -0400, Christoph Hellwig wrote:
> > diff --git a/include/builddefs.in b/include/builddefs.in
> > index 4c8ec64..81ebfcd 100644
> > --- a/include/builddefs.in
> > +++ b/include/builddefs.in
> > @@ -25,6 +25,7 @@ OPTIMIZER = @opt_build@
> > MALLOCLIB = @malloc_lib@
> > LOADERFLAGS = @LDFLAGS@
> > LTLDFLAGS = @LDFLAGS@
> > +CFLAGS = @CFLAGS@
> >
> > LIBRT = @librt@
> > LIBUUID = @libuuid@
> >
> > Then I don't have to set an environment variable when running make; I
> > just have to pass it to configure.
>
> This looks much better, and is indeed similar to some other fixes we
> recently had to put in, probably due to changing make behaviour.
>
> If you add a signoff and a proper description I'll put it into all the
> repositories.
Can you at least provide the signoff? I can take care of the rest if
this means I can get it in ASAP.
next prev parent reply other threads:[~2011-07-26 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 23:50 [PATCH XFSPROGS 1/3] configure.in: Declare a requirement for at least autoconf 2.50 Theodore Ts'o
2011-07-21 23:50 ` [PATCH XFSPROGS 2/3] Build without enabling DEBUG by default Theodore Ts'o
2011-07-22 14:17 ` Christoph Hellwig
2011-07-22 18:30 ` Ted Ts'o
2011-07-22 18:38 ` Christoph Hellwig
2011-07-22 22:30 ` Alex Elder
2011-07-22 22:34 ` Ted Ts'o
2011-07-23 1:32 ` Christoph Hellwig
2011-07-26 15:10 ` Christoph Hellwig [this message]
2011-07-30 16:55 ` Christoph Hellwig
2011-08-01 21:58 ` [PATCH] Build using CFLAGS passed in at configure Theodore Ts'o
2011-08-02 10:03 ` Christoph Hellwig
2011-07-21 23:50 ` [PATCH XFSPROGS 3/3] mkfs: Link against libuuid after liblkid Theodore Ts'o
2011-07-22 14:29 ` Christoph Hellwig
2011-07-22 14:28 ` [PATCH XFSPROGS 1/3] configure.in: Declare a requirement for at least autoconf 2.50 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726151033.GA18311@infradead.org \
--to=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).