From: Ted Ts'o <tytso@mit.edu>
To: Robin Dong <hao.bigrat@gmail.com>
Cc: linux-ext4@vger.kernel.org, Robin Dong <sanbai@taobao.com>
Subject: Re: [PATCH] ext4: add action of moving index in ext4_ext_rm_idx for Punch Hole
Date: Wed, 27 Jul 2011 21:33:04 -0400 [thread overview]
Message-ID: <20110728013304.GC3133@thunk.org> (raw)
In-Reply-To: <1311665699-22023-1-git-send-email-hao.bigrat@gmail.com>
On Tue, Jul 26, 2011 at 03:34:59PM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
>
> The old function ext4_ext_rm_idx is used only for truncate case because
> it just remove last index in extent-index-block. When punching hole,
> it usually needed to remove "middle" index, therefore we must move indexes
> which after it forward.
>
> (I create a file with 1 depth extent tree and punch hole in the middle of it,
> the last index in index-block strangly gone, so I find out this bug)
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
Thanks, added to the ext4 tree.
- Ted
prev parent reply other threads:[~2011-07-28 1:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 7:34 [PATCH] ext4: add action of moving index in ext4_ext_rm_idx for Punch Hole Robin Dong
2011-07-28 1:33 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728013304.GC3133@thunk.org \
--to=tytso@mit.edu \
--cc=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sanbai@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).