From: Ted Ts'o <tytso@mit.edu>
To: Utako Kusaka <u-kusaka@wm.jp.nec.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Add missing cast in ext4_fallocate
Date: Wed, 27 Jul 2011 22:12:11 -0400 [thread overview]
Message-ID: <20110728021211.GD3133@thunk.org> (raw)
In-Reply-To: <4E2D1C5D.6070103@wm.jp.nec.com>
On Mon, Jul 25, 2011 at 04:33:49PM +0900, Utako Kusaka wrote:
> Cast map.m_lblk to loff_t.
>
> File size is corrupt when we get an ENOSPC.
> Logical block number is __u32, so new_size will be set to overflowed value.
>
> # df -T /mnt/mp1
> Filesystem Type 1K-blocks Used Available Use% Mounted on
> /dev/sda6 ext4 9843276 153056 9190200 2% /mnt/mp1
> # fallocate -o 0 -l 2199023251456 /mnt/mp1/testfile
> fallocate: /mnt/mp1/testfile: fallocate failed: No space left on device
> # stat /mnt/mp1/testfile
> File: `/mnt/mp1/testfile'
> Size: 4293656576 Blocks: 19380440 IO Block: 4096 regular file
> Device: 806h/2054d Inode: 12 Links: 1
> Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root)
> Access: 2011-07-25 13:01:31.414490496 +0900
> Modify: 2011-07-25 13:01:31.414490496 +0900
> Change: 2011-07-25 13:01:31.454490495 +0900
>
> Signed-off-by: Utako Kusaka <u-kusaka@wm.jp.nec.com>
Thanks, added to the ext4 tree.
- Ted
prev parent reply other threads:[~2011-07-28 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 7:33 [PATCH] ext4: Add missing cast in ext4_fallocate Utako Kusaka
2011-07-28 2:12 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728021211.GD3133@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=u-kusaka@wm.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).