From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <error27@gmail.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
"open list:EXT4 FILE SYSTEM" <linux-ext4@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: add a kfree() on error i add_new_gdb()
Date: Sat, 30 Jul 2011 12:59:39 -0400 [thread overview]
Message-ID: <20110730165939.GJ7361@thunk.org> (raw)
In-Reply-To: <20110730082557.GB5575@shale.localdomain>
On Sat, Jul 30, 2011 at 11:25:57AM +0300, Dan Carpenter wrote:
> We added some more error handling in b40971426a "ext4: add error
> checking to calls to ext4_handle_dirty_metadata()". But we need to
> call kfree() as well to avoid a memory leak.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Added to the ext4 tree, thanks for catching this!!
- Ted
prev parent reply other threads:[~2011-07-30 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 8:25 [patch] ext4: add a kfree() on error i add_new_gdb() Dan Carpenter
2011-07-30 16:59 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110730165939.GJ7361@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).