From: Jan Kara <jack@suse.cz>
To: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
Cc: Jan Kara <jack@suse.cz>,
akpm@linux-foundation.org, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext3: fix message in ext3_remount for rw-remount case
Date: Mon, 1 Aug 2011 11:57:31 +0200 [thread overview]
Message-ID: <20110801095731.GI6522@quack.suse.cz> (raw)
In-Reply-To: <4E3675D6.3010201@jp.fujitsu.com>
On Mon 01-08-11 18:45:58, Toshiyuki Okajima wrote:
> (2011/08/01 17:45), Jan Kara wrote:
> >On Mon 01-08-11 13:54:51, Toshiyuki Okajima wrote:
> >>If there are some inodes in orphan list while a filesystem is being
> >>read-only mounted, we should recommend that pepole umount and then
> >>mount it when they try to remount with read-write. But the current
> >>message/comment recommends that they umount and then remount it.
> >>
> >>ext3_remount:
> >> /*
> >> * If we have an unprocessed orphan list hanging
> >> * around from a previously readonly bdev mount,
> >> * require a full umount/remount for now.
> >> ^^^^^^^^^^^^^^
> >> */
> >> if (es->s_last_orphan) {
> >> printk(KERN_WARNING "EXT3-fs: %s: couldn't "
> >> "remount RDWR because of unprocessed "
> >> "orphan inode list. Please "
> >> "umount/remount instead.\n",
> >> ^^^^^^^^^^^^^^
> >> sb->s_id);
>
> > OK, so how about using "umount& mount"? The '/' is what would confuse me
> OK. I modify it like your comment.
>
> umount/mount => umount & mount
Thanks.
> >the most... BTW, I guess you didn't really see this message in practice, did
> >you?
> No.
> I have seen this message in practice while quotacheck command was repeatedly
> executed per an hour.
Interesting. Are you able to reproduce this? Quotacheck does remount
read-only + remount read-write but you cannot really remount the filesystem
read-only when it has orphan inodes and so you should not see those when
you remount read-write again. Possibly there's race between remounting and
unlinking...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-08-01 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 4:54 [PATCH] ext3: fix message in ext3_remount for rw-remount case Toshiyuki Okajima
2011-08-01 8:45 ` Jan Kara
2011-08-01 9:45 ` Toshiyuki Okajima
2011-08-01 9:57 ` Jan Kara [this message]
2011-08-02 9:14 ` Toshiyuki Okajima
2011-08-03 2:42 ` Toshiyuki Okajima
2011-08-03 9:57 ` Jan Kara
2011-08-03 13:25 ` Toshiyuki Okajima
2011-08-03 16:25 ` Jan Kara
2011-08-08 4:27 ` Toshiyuki Okajima
2011-08-08 12:48 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801095731.GI6522@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=toshi.okajima@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).