From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: get free blocks count of BLOCK_UNINIT groups from group desc directly
Date: Mon, 1 Aug 2011 07:20:15 -0400 [thread overview]
Message-ID: <20110801112015.GB21388@thunk.org> (raw)
In-Reply-To: <1311168774-26378-2-git-send-email-xiaoqiangnk@gmail.com>
On Wed, Jul 20, 2011 at 09:32:53PM +0800, Yongqiang Yang wrote:
> This patch teaches ext4 to get free blocks count of BLOCK_UNINIT groups from
> group desc directly.
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
The reason why we weren't doing this is because older versions of
e2fsprogs I don't think set the free blocks count correctly. Or at
least, I have a vague memory that this was the case. I'll have to do
some code archeology before can be 100% sure this is safe to do.
Regards,
- Ted
next prev parent reply other threads:[~2011-08-01 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 13:32 ext4: let ext4 get free blocks count of uninit groups from desc Yongqiang Yang
2011-07-20 13:32 ` [PATCH 1/2] ext4: get free blocks count of BLOCK_UNINIT groups from group desc directly Yongqiang Yang
2011-08-01 11:20 ` Ted Ts'o [this message]
2011-08-02 3:15 ` Andreas Dilger
2011-07-20 13:32 ` [PATCH 2/2] ext4: remove ext4_free_blocks_after_init() Yongqiang Yang
2011-07-20 15:41 ` Andreas Dilger
2011-07-21 1:37 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801112015.GB21388@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).