linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Aditya Kali <adityakali@google.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: make quota as first class supported feature
Date: Mon, 1 Aug 2011 12:44:57 -0400	[thread overview]
Message-ID: <20110801164457.GE21388@thunk.org> (raw)
In-Reply-To: <20110801140034.GC21388@thunk.org>

[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]

On Mon, Aug 01, 2011 at 10:00:34AM -0400, Ted Ts'o wrote:
> On Wed, Jul 20, 2011 at 11:40:18AM -0700, Aditya Kali wrote:
> > This patch is an attempt towards supporting quotas as first class
> > feature in ext4. It is based on the proposal at:
> > https://ext4.wiki.kernel.org/index.php/Design_For_1st_Class_Quota_in_Ext4
> > ...
> >
> > Signed-off-by: Aditya Kali <adityakali@google.com>
> 
> Thanks, added to the ext4 tree.

Hmm, this caused a bunch of quota test failures that shouldn't be
happening....

Ran: 001 002 005 006 007 011 013 014 053 069 070 074 075 076 077 088 089 100 105 112 113 123 124 125 126 127 128 129 130 131 132 133 135 141 169 184 193 198 204 207 208 209 210 211 212 213 214 215 219 221 223 224 225 226 228 230 231 232 233 234 235 236 237 239 240 243
Failures: 219 230 231 232 233 235

It looks like the backwards compatibility with traditional quota
setups isn't quite working correctly:

230 21s ... - output mismatch (see 230.out.bad)

--- 230.out 2011-07-21 19:27:10.000000000 -0400
+++ 230.out.bad	       2011-08-01 10:46:59.470964400 -0400
@@ -7,14 +7,10 @@
 Write 900k...
 Rewrite 1001k...
 Write 1000k...
-pwrite64: Disk quota exceeded
 Write 4096...
-pwrite64: Disk quota exceeded
 Touch 3+4
 Touch 5+6
-touch: cannot touch `SCRATCH_MNT/file6': Disk quota exceeded
 Touch 5
-touch: cannot touch `SCRATCH_MNT/file5': Disk quota exceeded
	...

I may end up putting this off until the next merge window, unless we
can fix this quickly.

    	     				- Ted
       

[-- Attachment #2: xfstests-quota.log.gz --]
[-- Type: application/octet-stream, Size: 57516 bytes --]

  reply	other threads:[~2011-08-01 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 18:40 [PATCH] ext4: make quota as first class supported feature Aditya Kali
     [not found] ` <561996F3-BC30-4E1A-B405-0A13A966E45A@dilger.ca>
2011-07-21 17:24   ` Aditya Kali
2011-08-01 14:00 ` Ted Ts'o
2011-08-01 16:44   ` Ted Ts'o [this message]
     [not found]     ` <CAGr1F2F5Je=LFVm0Z9N3+ThstvEf5XiWPYMqjemri6F5aHossQ@mail.gmail.com>
2011-08-05 17:32       ` Aditya Kali
  -- strict thread matches above, loose matches on Subject: below --
2011-12-10  0:08 Aditya Kali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110801164457.GE21388@thunk.org \
    --to=tytso@mit.edu \
    --cc=adityakali@google.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).