* [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization [not found] <1312453774-23333-1-git-send-email-julia@diku.dk> @ 2011-08-04 10:29 ` Julia Lawall 2011-08-04 10:40 ` Jan Kara 2011-08-04 10:29 ` [PATCH 2/4] fs/ext2/balloc.c: " Julia Lawall 1 sibling, 1 reply; 6+ messages in thread From: Julia Lawall @ 2011-08-04 10:29 UTC (permalink / raw) To: Jan Kara Cc: kernel-janitors, Andrew Morton, Andreas Dilger, linux-ext4, linux-kernel From: Julia Lawall <julia@diku.dk> Delete nontrivial initialization that is immediately overwritten by the result of an allocation function. The semantic match that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; identifier i; expression e; @@ ( T i = \(0\|NULL\|ERR_PTR(...)\); | -T i = e; +T i; ) ... when != i i = \(kzalloc\|kcalloc\|kmalloc\)(...); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> --- fs/ext3/balloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/fs/ext3/balloc.c b/fs/ext3/balloc.c --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c @@ -427,7 +427,7 @@ static inline int rsv_is_empty(struct ex void ext3_init_block_alloc_info(struct inode *inode) { struct ext3_inode_info *ei = EXT3_I(inode); - struct ext3_block_alloc_info *block_i = ei->i_block_alloc_info; + struct ext3_block_alloc_info *block_i; struct super_block *sb = inode->i_sb; block_i = kmalloc(sizeof(*block_i), GFP_NOFS); ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization 2011-08-04 10:29 ` [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization Julia Lawall @ 2011-08-04 10:40 ` Jan Kara 2011-08-05 17:24 ` Eric Sandeen 0 siblings, 1 reply; 6+ messages in thread From: Jan Kara @ 2011-08-04 10:40 UTC (permalink / raw) To: Julia Lawall Cc: Jan Kara, kernel-janitors, Andrew Morton, Andreas Dilger, linux-ext4, linux-kernel On Thu 04-08-11 12:29:31, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Delete nontrivial initialization that is immediately overwritten by the > result of an allocation function. Thanks. Merged. Honza > > The semantic match that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > type T; > identifier i; > expression e; > @@ > > ( > T i = \(0\|NULL\|ERR_PTR(...)\); > | > -T i = e; > +T i; > ) > ... when != i > i = \(kzalloc\|kcalloc\|kmalloc\)(...); > > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > fs/ext3/balloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/fs/ext3/balloc.c b/fs/ext3/balloc.c > --- a/fs/ext3/balloc.c > +++ b/fs/ext3/balloc.c > @@ -427,7 +427,7 @@ static inline int rsv_is_empty(struct ex > void ext3_init_block_alloc_info(struct inode *inode) > { > struct ext3_inode_info *ei = EXT3_I(inode); > - struct ext3_block_alloc_info *block_i = ei->i_block_alloc_info; > + struct ext3_block_alloc_info *block_i; > struct super_block *sb = inode->i_sb; > > block_i = kmalloc(sizeof(*block_i), GFP_NOFS); > -- Jan Kara <jack@suse.cz> SUSE Labs, CR ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization 2011-08-04 10:40 ` Jan Kara @ 2011-08-05 17:24 ` Eric Sandeen 2011-08-05 19:08 ` Julia Lawall 0 siblings, 1 reply; 6+ messages in thread From: Eric Sandeen @ 2011-08-05 17:24 UTC (permalink / raw) To: Jan Kara; +Cc: Julia Lawall, linux-ext4 On 8/4/11 5:40 AM, Jan Kara wrote: > On Thu 04-08-11 12:29:31, Julia Lawall wrote: >> From: Julia Lawall <julia@diku.dk> >> >> Delete nontrivial initialization that is immediately overwritten by the >> result of an allocation function. > Thanks. Merged. Just FWIW, I was curious how this ended up here. It looks like this has been there since 2005, and both lines went in in the same commit (i.e. it didn't creep in over time). http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=a66d457d8878fe8d09bc81f0d5e6ac40caec6eb7 -Eric > Honza > >> >> The semantic match that makes this change is as follows: >> (http://coccinelle.lip6.fr/) >> >> // <smpl> >> @@ >> type T; >> identifier i; >> expression e; >> @@ >> >> ( >> T i = \(0\|NULL\|ERR_PTR(...)\); >> | >> -T i = e; >> +T i; >> ) >> ... when != i >> i = \(kzalloc\|kcalloc\|kmalloc\)(...); >> >> // </smpl> >> >> Signed-off-by: Julia Lawall <julia@diku.dk> >> >> --- >> fs/ext3/balloc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -u -p a/fs/ext3/balloc.c b/fs/ext3/balloc.c >> --- a/fs/ext3/balloc.c >> +++ b/fs/ext3/balloc.c >> @@ -427,7 +427,7 @@ static inline int rsv_is_empty(struct ex >> void ext3_init_block_alloc_info(struct inode *inode) >> { >> struct ext3_inode_info *ei = EXT3_I(inode); >> - struct ext3_block_alloc_info *block_i = ei->i_block_alloc_info; >> + struct ext3_block_alloc_info *block_i; >> struct super_block *sb = inode->i_sb; >> >> block_i = kmalloc(sizeof(*block_i), GFP_NOFS); >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization 2011-08-05 17:24 ` Eric Sandeen @ 2011-08-05 19:08 ` Julia Lawall 0 siblings, 0 replies; 6+ messages in thread From: Julia Lawall @ 2011-08-05 19:08 UTC (permalink / raw) To: Eric Sandeen; +Cc: Jan Kara, linux-ext4 On Fri, 5 Aug 2011, Eric Sandeen wrote: > On 8/4/11 5:40 AM, Jan Kara wrote: > > On Thu 04-08-11 12:29:31, Julia Lawall wrote: > >> From: Julia Lawall <julia@diku.dk> > >> > >> Delete nontrivial initialization that is immediately overwritten by the > >> result of an allocation function. > > Thanks. Merged. > > Just FWIW, I was curious how this ended up here. > > It looks like this has been there since 2005, and both > lines went in in the same commit (i.e. it didn't creep in over time). > > http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=a66d457d8878fe8d09bc81f0d5e6ac40caec6eb7 Actually, the old code had the same property, for the rsv variable... julia ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/4] fs/ext2/balloc.c: delete useless initialization [not found] <1312453774-23333-1-git-send-email-julia@diku.dk> 2011-08-04 10:29 ` [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization Julia Lawall @ 2011-08-04 10:29 ` Julia Lawall 2011-08-04 10:39 ` Jan Kara 1 sibling, 1 reply; 6+ messages in thread From: Julia Lawall @ 2011-08-04 10:29 UTC (permalink / raw) To: Jan Kara; +Cc: kernel-janitors, linux-ext4, linux-kernel From: Julia Lawall <julia@diku.dk> Delete nontrivial initialization that is immediately overwritten by the result of an allocation function. The semantic match that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; identifier i; expression e; @@ ( T i = \(0\|NULL\|ERR_PTR(...)\); | -T i = e; +T i; ) ... when != i i = \(kzalloc\|kcalloc\|kmalloc\)(...); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> --- fs/ext2/balloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/fs/ext2/balloc.c b/fs/ext2/balloc.c --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -421,7 +421,7 @@ static inline int rsv_is_empty(struct ex void ext2_init_block_alloc_info(struct inode *inode) { struct ext2_inode_info *ei = EXT2_I(inode); - struct ext2_block_alloc_info *block_i = ei->i_block_alloc_info; + struct ext2_block_alloc_info *block_i; struct super_block *sb = inode->i_sb; block_i = kmalloc(sizeof(*block_i), GFP_NOFS); ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4] fs/ext2/balloc.c: delete useless initialization 2011-08-04 10:29 ` [PATCH 2/4] fs/ext2/balloc.c: " Julia Lawall @ 2011-08-04 10:39 ` Jan Kara 0 siblings, 0 replies; 6+ messages in thread From: Jan Kara @ 2011-08-04 10:39 UTC (permalink / raw) To: Julia Lawall; +Cc: Jan Kara, kernel-janitors, linux-ext4, linux-kernel On Thu 04-08-11 12:29:32, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Delete nontrivial initialization that is immediately overwritten by the > result of an allocation function. Thanks. Merged. Honza > > The semantic match that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > type T; > identifier i; > expression e; > @@ > > ( > T i = \(0\|NULL\|ERR_PTR(...)\); > | > -T i = e; > +T i; > ) > ... when != i > i = \(kzalloc\|kcalloc\|kmalloc\)(...); > > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > fs/ext2/balloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/fs/ext2/balloc.c b/fs/ext2/balloc.c > --- a/fs/ext2/balloc.c > +++ b/fs/ext2/balloc.c > @@ -421,7 +421,7 @@ static inline int rsv_is_empty(struct ex > void ext2_init_block_alloc_info(struct inode *inode) > { > struct ext2_inode_info *ei = EXT2_I(inode); > - struct ext2_block_alloc_info *block_i = ei->i_block_alloc_info; > + struct ext2_block_alloc_info *block_i; > struct super_block *sb = inode->i_sb; > > block_i = kmalloc(sizeof(*block_i), GFP_NOFS); > -- Jan Kara <jack@suse.cz> SUSE Labs, CR ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-05 19:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1312453774-23333-1-git-send-email-julia@diku.dk>
2011-08-04 10:29 ` [PATCH 1/4] fs/ext3/balloc.c: delete useless initialization Julia Lawall
2011-08-04 10:40 ` Jan Kara
2011-08-05 17:24 ` Eric Sandeen
2011-08-05 19:08 ` Julia Lawall
2011-08-04 10:29 ` [PATCH 2/4] fs/ext2/balloc.c: " Julia Lawall
2011-08-04 10:39 ` Jan Kara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).