From: Ted Ts'o <tytso@mit.edu>
To: Robin Dong <hao.bigrat@gmail.com>
Cc: linux-ext4@vger.kernel.org, Robin Dong <sanbai@taobao.com>
Subject: Re: [PATCH 1/2 bigalloc] e2fsprogs: remove wrong EXT2FS_C2B in check_block_end
Date: Wed, 10 Aug 2011 22:49:33 -0400 [thread overview]
Message-ID: <20110811024933.GC3625@thunk.org> (raw)
In-Reply-To: <1312429682-16970-2-git-send-email-hao.bigrat@gmail.com>
On Thu, Aug 04, 2011 at 11:48:02AM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
>
> The argument "save_blocks_count" and the block bitmap has the unit of cluster,
> so it don't need EXT2FS_C2B to convert argument "i".
>
> This patch is based on "next" branch of e2fsprogs.
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
> Cc: Ted Ts'o <tytso@mit.edu>
No, I don't think this is right. Regardless of whether the unit of
the block bitmap is cluster- or block- (only while mke2fs is running,
and only initially) based, the argument to
ext2fs_{test,mark,unmark}_block_bitmap is always in blocks.
That's why the EXT2FS_C2B is necessary.
- Ted
next prev parent reply other threads:[~2011-08-11 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 3:48 [PATCH 2/2 bigalloc] ext4: modify offset to cluster in ext4_valid_block_bitmap Robin Dong
2011-08-04 3:48 ` [PATCH 1/2 bigalloc] e2fsprogs: remove wrong EXT2FS_C2B in check_block_end Robin Dong
2011-08-11 2:49 ` Ted Ts'o [this message]
2011-08-12 3:44 ` Robin Dong
2011-08-11 2:51 ` [PATCH 2/2 bigalloc] ext4: modify offset to cluster in ext4_valid_block_bitmap Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811024933.GC3625@thunk.org \
--to=tytso@mit.edu \
--cc=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sanbai@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).