* Re: Question about BIGALLOC
2011-08-05 7:59 Question about BIGALLOC Robin Dong
@ 2011-08-11 2:59 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-08-11 2:59 UTC (permalink / raw)
To: Robin Dong; +Cc: linux-ext4
On Fri, Aug 05, 2011 at 03:59:01PM +0800, Robin Dong wrote:
> Hi, Ted
>
> I am doing some test of BIGALLOC using "next" branch of e2fsprogs and
> kernel (3.0) with 23 bigalloc-patches.
>
> Everything seems to work, but I have a question:
> the "ee_len" of "struct ext4_extent" is used to indicate block numbers
> not cluster,
> an ext4_extent in 4K-block-size filesystem can only hold 128MB space at most
> even with BIGALLOC feature enabled, so we don't have any benefit from
> this for a file with large number of blocks.
>
> Is this the design behavior or you will change it in the next version?
It's not something I can change, because the VM subsystem
fundamentally assumes that file system block size is less than or
equal to the page size. If I changed the granularity in the extent
length, then in the case of a sparse file, blocks would have to be
allocated and zero'ed in units of a cluster. The VM doesn't support
this well.
For example, suppose you fallocate a file to be 1 megabyte. That
means that you have a 1mb extent which is marked as uninitialized.
Now suppose you mmap() this file, and then you write a single byte at
offset 20480. This dirties a single 4k page, and when we write out
that page, we end up converting the 1mb extent uninitialized extent
into 3 extents: a 20k uninitalized extent, a 4k initialized extent,
and a 1000k uninitalized extent. Now suppose this was done on a
bigalloc file system with a 64k cluster size. If ee_len was
denominated in 64k cluster chunks, we couldn't express the concept of
a 20k or 4k extent.
This is the same reason why we can't support a 64k file system block
size. If the user dirties a single 4k block in an otherwise sparse
file, the VM would have to instantiate the other 56k pages and zero
them (atomically!) --- and the VM doesn't know how to do this.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread