From: Jan Kara <jack@suse.cz>
To: Ted Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Lukas Czerner <lczerner@redhat.com>,
Curt Wohlgemuth <curtw@google.com>,
Ric Wheeler <rwheeler@redhat.com>,
Andreas Dilger <adilger@dilger.ca>,
linux-ext4 List <linux-ext4@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH v2] ext4: Deprecate data=journal mount option
Date: Mon, 15 Aug 2011 13:19:02 +0200 [thread overview]
Message-ID: <20110815111902.GA6597@quack.suse.cz> (raw)
In-Reply-To: <20110814020617.GB3524@thunk.org>
On Sat 13-08-11 22:06:17, Ted Tso wrote:
> On Fri, Aug 12, 2011 at 04:57:19PM -0400, Christoph Hellwig wrote:
> > > and differences in error code returns for
> > > xattrs) and #79 (a failure in the append-only handling which I don't
> > > completely understand yet).
> >
> > This was discussed on fsdevel lately. All filesystem but xfs inherit
> > the append only bit from directories to files created inside them.
> > This not only is not very useful behaviour, but also exposes a bug
> > in the vfs that allows to create these new files, but fail the open
> > unless using O_APPEND which is against the posix create semantics.
>
> I agree that disabling inheritance of the APPEND_FL flag makes sense.
> I propose we do this for ext2/3/4 and any other file systems which is
> currently following the ext2/3/4 behavior.
>
> Any objections?
I'm fine with that. It also looks more like a bug (ommission) than
anything else.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2011-08-15 11:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 11:26 [PATCH v2] ext4: Deprecate data=journal mount option Lukas Czerner
2011-06-29 4:49 ` Bruce Guenter
2011-06-29 11:49 ` Lukas Czerner
2011-08-11 15:01 ` Lukas Czerner
2011-08-11 21:08 ` Andreas Dilger
2011-08-12 8:16 ` Lukas Czerner
2011-08-12 8:25 ` Ric Wheeler
2011-08-12 15:45 ` Curt Wohlgemuth
2011-08-12 16:08 ` Lukas Czerner
2011-08-12 18:13 ` Ted Ts'o
2011-08-12 20:57 ` Christoph Hellwig
2011-08-14 2:06 ` Ted Ts'o
2011-08-14 2:28 ` [PATCH] ext2,ext3,ext4: don't inherit APPEND_FL or IMMUTABLE_FL for new inodes Theodore Ts'o
2011-12-22 18:06 ` Eric Sandeen
2011-12-22 18:19 ` Ted Ts'o
2011-12-22 18:23 ` Eric Sandeen
2011-08-15 11:19 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110815111902.GA6597@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger@dilger.ca \
--cc=curtw@google.com \
--cc=hch@infradead.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).