From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Bob Pearson <rpearson@systemfabricworks.com>
Cc: "'Andreas Dilger'" <adilger.kernel@dilger.ca>,
"'Herbert Xu'" <herbert@gondor.apana.org.au>,
"'Theodore Tso'" <tytso@mit.edu>,
"'David Miller'" <davem@davemloft.net>,
"'linux-kernel'" <linux-kernel@vger.kernel.org>,
"'Mingming Cao'" <cmm@us.ibm.com>,
"'linux-crypto'" <linux-crypto@vger.kernel.org>,
"'linux-fsdevel'" <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] crc32c: Implement a self-test for CRC32c
Date: Thu, 1 Sep 2011 15:18:54 -0700 [thread overview]
Message-ID: <20110901221854.GA12086@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <03ac01cc6869$9cd23b60$d676b220$@systemfabricworks.com>
On Thu, Sep 01, 2011 at 12:40:08AM -0500, Bob Pearson wrote:
> Hi Darrick,
>
> The same code in crc32.c was helpful to measure performance and help code
> tuning as well as indicate correctness. Otherwise the code in crypto may be
> enough to test all the corner cases. If this survives the review I wonder if
> there is a way to combine crc32 and crc32c together somehow. I like yours
> because you can load/unload and not need the memory permanently.
I suspect it would be pretty easy to adapt the Makefile to generate the
relevant .c and .h files; in particular it could be useful to use the crypto
framework for crc32 on the off chance anyone wants to provide hwaccel for that
too.
That said, merging libcrc32c-test vectors with the existing one (sorry, I
didn't realize that existed) shouldn't be too difficult.
--D
next prev parent reply other threads:[~2011-09-01 22:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 0:33 [PATCH v1 0/3] crc32c: Add faster algorithm and self-test code Darrick J. Wong
2011-09-01 0:33 ` [PATCH 1/3] crc32c: Implement CRC32c with slicing-by-8 algorithm Darrick J. Wong
2011-09-01 0:33 ` [PATCH 2/3] libcrc32c: Expose big-endian version of crc32c Darrick J. Wong
2011-09-01 0:33 ` [PATCH 3/3] crc32c: Implement a self-test for CRC32c Darrick J. Wong
2011-09-01 1:07 ` Herbert Xu
2011-09-01 1:20 ` Bob Pearson
2011-09-01 1:51 ` Herbert Xu
2011-09-01 5:40 ` Bob Pearson
2011-09-01 6:41 ` Herbert Xu
2011-09-01 22:18 ` Darrick J. Wong [this message]
2011-09-01 22:24 ` Christoph Hellwig
2011-09-01 22:28 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2011-09-27 22:12 [PATCH v2 0/3] crc32c: Add faster algorithm and self-test code Darrick J. Wong
2011-09-27 22:13 ` [PATCH 3/3] crc32c: Implement a self-test for CRC32c Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901221854.GA12086@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmm@us.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpearson@systemfabricworks.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).