From: Tejun Heo <tj@kernel.org>
To: Theodore Tso <tytso@MIT.EDU>
Cc: Anton Blanchard <anton@samba.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] percpu_counter: Put a reasonable upper bound on percpu_counter_batch
Date: Wed, 7 Sep 2011 01:44:58 +0900 [thread overview]
Message-ID: <20110906164458.GI18425@mtj.dyndns.org> (raw)
In-Reply-To: <EEB2FCE2-3C14-406E-BD0E-FD27D091C492@mit.edu>
On Tue, Sep 06, 2011 at 09:30:50AM -0400, Theodore Tso wrote:
> >> I chose to cap percpu_counter_batch at 1024 as a conservative first
> >> step, but we may want to reduce it further based on further benchmarking.
> >>
> >> Signed-off-by: Anton Blanchard <anton@samba.org>
> >
> > Applied to percpu/for-3.2.
>
> Um, this was an ext4 patch and I pointed out it could cause problems. (Specifically, data loss…)
Ah okay, I thought you were talking about the first patch only.
Reverting for now.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-06 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 21:26 [PATCH 1/2] ext4: EXT4_FREEBLOCKS_WATERMARK is overly pessimistic Anton Blanchard
2011-08-25 21:29 ` [PATCH 2/2] percpu_counter: Put a reasonable upper bound on percpu_counter_batch Anton Blanchard
2011-08-26 8:39 ` Eric Dumazet
2011-08-29 11:46 ` [PATCH] " Anton Blanchard
2011-09-06 3:48 ` Tejun Heo
2011-09-06 13:30 ` Theodore Tso
2011-09-06 16:44 ` Tejun Heo [this message]
2011-09-07 11:08 ` Anton Blanchard
2011-08-26 9:00 ` [PATCH 2/2] " Tejun Heo
2011-08-26 11:48 ` Theodore Tso
2011-08-29 11:54 ` Anton Blanchard
2011-08-29 13:27 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906164458.GI18425@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=anton@samba.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).