From: Jan Kara <jack@suse.cz>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, achender@linux.vnet.ibm.com,
adityakali@google.com, tytso@mit.edu
Subject: Re: [RFC PATCH 3/5] ext4: add operations on delayed extent tree
Date: Thu, 8 Sep 2011 20:58:51 +0200 [thread overview]
Message-ID: <20110908185851.GB2393@quack.suse.cz> (raw)
In-Reply-To: <1314694821-17213-4-git-send-email-xiaoqiangnk@gmail.com>
On Tue 30-08-11 17:00:19, Yongqiang Yang wrote:
> This patch adds operations on a delayed extent tree.
>
> Signed-off-by; Yongqiang Yang <xiaoqiangnk@gmail.com>
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
I don't have time to do a full review of the series now but I definitely
think you should use RB tree to track extents. For big files written in
random manner we will just burn lots of CPU cycles needlessly...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-09-10 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 9:00 [RFC] implementation of delayed extent list Yongqiang Yang
2011-08-30 9:00 ` [RFC PATCH 1/5] ext4: add two structures delayed extent list nees Yongqiang Yang
2011-08-30 9:00 ` [RFC PATCH 2/5] ext4: add a delayed extents list in inode Yongqiang Yang
2011-08-30 9:00 ` [RFC PATCH 3/5] ext4: add operations on delayed extent tree Yongqiang Yang
2011-09-08 18:58 ` Jan Kara [this message]
2011-09-09 1:14 ` Yongqiang Yang
2011-09-09 2:46 ` Yongqiang Yang
2011-09-09 9:32 ` Lukas Czerner
2011-08-30 9:00 ` [RFC PATCH 4/5] ext4: let ext4 maintian delayed extent lists Yongqiang Yang
2011-08-30 9:00 ` [RFC PATCH 5/5] ext4: reimplement fiemap on delayed extent list Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908185851.GB2393@quack.suse.cz \
--to=jack@suse.cz \
--cc=achender@linux.vnet.ibm.com \
--cc=adityakali@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).