From: Jan Kara <jack@suse.cz>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu
Subject: Re: [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure
Date: Thu, 15 Sep 2011 14:28:00 +0200 [thread overview]
Message-ID: <20110915122800.GA4739@quack.suse.cz> (raw)
In-Reply-To: <1316055390-14476-1-git-send-email-xiaoqiangnk@gmail.com>
On Thu 15-09-11 10:56:30, Yongqiang Yang wrote:
> The started journal handle should be stopped in failure case.
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Correct.
Acked-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/inode.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index bcf5257..c8529be 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -4624,6 +4624,7 @@ retry_alloc:
> PAGE_CACHE_SIZE, NULL, do_journal_get_write_access)) {
> unlock_page(page);
> ret = VM_FAULT_SIGBUS;
> + ext4_journal_stop(handle);
> goto out;
> }
> ext4_set_inode_state(inode, EXT4_STATE_JDATA);
> --
> 1.7.5.1
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-09-15 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 2:56 [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure Yongqiang Yang
2011-09-15 12:28 ` Jan Kara [this message]
2011-10-26 9:01 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915122800.GA4739@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).