* [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure
@ 2011-09-15 2:56 Yongqiang Yang
2011-09-15 12:28 ` Jan Kara
2011-10-26 9:01 ` Ted Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Yongqiang Yang @ 2011-09-15 2:56 UTC (permalink / raw)
To: linux-ext4; +Cc: jack, tytso, Yongqiang Yang
The started journal handle should be stopped in failure case.
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
fs/ext4/inode.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index bcf5257..c8529be 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4624,6 +4624,7 @@ retry_alloc:
PAGE_CACHE_SIZE, NULL, do_journal_get_write_access)) {
unlock_page(page);
ret = VM_FAULT_SIGBUS;
+ ext4_journal_stop(handle);
goto out;
}
ext4_set_inode_state(inode, EXT4_STATE_JDATA);
--
1.7.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure
2011-09-15 2:56 [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure Yongqiang Yang
@ 2011-09-15 12:28 ` Jan Kara
2011-10-26 9:01 ` Ted Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2011-09-15 12:28 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: linux-ext4, jack, tytso
On Thu 15-09-11 10:56:30, Yongqiang Yang wrote:
> The started journal handle should be stopped in failure case.
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Correct.
Acked-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/inode.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index bcf5257..c8529be 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -4624,6 +4624,7 @@ retry_alloc:
> PAGE_CACHE_SIZE, NULL, do_journal_get_write_access)) {
> unlock_page(page);
> ret = VM_FAULT_SIGBUS;
> + ext4_journal_stop(handle);
> goto out;
> }
> ext4_set_inode_state(inode, EXT4_STATE_JDATA);
> --
> 1.7.5.1
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure
2011-09-15 2:56 [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure Yongqiang Yang
2011-09-15 12:28 ` Jan Kara
@ 2011-10-26 9:01 ` Ted Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Ted Ts'o @ 2011-10-26 9:01 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: linux-ext4, jack
On Thu, Sep 15, 2011 at 10:56:30AM +0800, Yongqiang Yang wrote:
> The started journal handle should be stopped in failure case.
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-26 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-15 2:56 [PATCH] ext4: let ext4_page_mkwrite stop started handle in failure Yongqiang Yang
2011-09-15 12:28 ` Jan Kara
2011-10-26 9:01 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).