From: Ted Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
"Darrick J. Wong" <djwong@us.ibm.com>,
Sunil Mushran <sunil.mushran@oracle.com>,
Andi Kleen <andi@firstfloor.org>, Mingming Cao <cmm@us.ibm.com>,
Joel Becker <jlbec@evilplan.org>,
linux-ext4@vger.kernel.org, Coly Li <colyli@gmail.com>,
Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: Re: [PATCH] libext2fs: reserve exclude bitmap fields in group descriptor
Date: Thu, 15 Sep 2011 10:21:37 -0400 [thread overview]
Message-ID: <20110915142137.GH15782@thunk.org> (raw)
In-Reply-To: <CAOQ4uxgCqTEMBha-13aLy5mKExquK=3Ma5LheqKaPBzCo3PRCw@mail.gmail.com>
On Thu, Sep 15, 2011 at 05:03:37PM +0300, Amir Goldstein wrote:
> > I'd prefer if these comments were "Snapshot exclude bitmap block" so
> > that it is more clear what an exclude bitmap is used for.
>
> I'll change that.
I'll be sending out a combined patch very shortly which adds the
necessary fields for the snapshot and metadata checksum fields. I
just want to make sure we're all on the same page about reserved
fields as far as the on-disk format is concerned.
> >
> > For consistency, it would also be good to name these "_lo" to match the
> > kernel fields.
> >
>
> That's a major cleanup.
> Forgive me for not picking up that glove...
One way of handling these sorts of cleanups is to make the change in
the header file, and then do something like this:
#define bg_exclude_bitmap bg_exclude_bitmap_lo
Then once you add the accessor functions to set/get the
exclude_bitmap, you can delete the #define to make sure you fixed up
all of your code to actually use the accessor functions.
- Ted
next prev parent reply other threads:[~2011-09-15 14:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 6:50 [PATCH] libext2fs: reserve exclude bitmap fields in group descriptor Amir Goldstein
2011-09-15 10:06 ` Andreas Dilger
2011-09-15 14:03 ` Amir Goldstein
2011-09-15 14:21 ` Ted Ts'o [this message]
2011-09-15 13:16 ` Ted Ts'o
2011-09-15 13:47 ` Amir Goldstein
2011-09-15 19:08 ` Andreas Dilger
2011-09-15 21:57 ` Ted Ts'o
2011-09-16 6:45 ` Amir Goldstein
2011-09-16 11:43 ` Yongqiang Yang
2011-09-16 20:22 ` Andreas Dilger
2011-09-16 6:55 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915142137.GH15782@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=andi@firstfloor.org \
--cc=cmm@us.ibm.com \
--cc=colyli@gmail.com \
--cc=djwong@us.ibm.com \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sunil.mushran@oracle.com \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox