From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, adilger@dilger.ca
Subject: Re: [PATCH 4/5 v2] e2fsck: do not attempt to discard if -n was specified
Date: Thu, 15 Sep 2011 23:53:31 -0400 [thread overview]
Message-ID: <20110916035331.GU28181@thunk.org> (raw)
In-Reply-To: <1313167380-3283-4-git-send-email-lczerner@redhat.com>
On Fri, Aug 12, 2011 at 06:42:59PM +0200, Lukas Czerner wrote:
> If '-n' option is specified there should be no changes made to the file
> system hence we should not attempt to discard the file system. This
> commit adds a check into the e2fsck_discard_blocks() condition so it skip
> discard if E2F_OPT_NO flag is set.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied to the next branch.
- Ted
next prev parent reply other threads:[~2011-09-16 3:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 16:42 [PATCH 1/5 v2] e2fsprogs: create open() and stat() helpers Lukas Czerner
2011-08-12 16:42 ` [PATCH 2/5 v2] e2fsprogs: Use punch hole as "discard" on regular files Lukas Czerner
2011-09-16 3:50 ` Ted Ts'o
2011-08-12 16:42 ` [PATCH 3/5 v2] configure.in: add check for linux/falloc.h header Lukas Czerner
2011-08-12 16:42 ` [PATCH 4/5 v2] e2fsck: do not attempt to discard if -n was specified Lukas Czerner
2011-09-16 3:53 ` Ted Ts'o [this message]
2011-08-12 16:43 ` [PATCH 5/5 v2] tests: Print out list of failed tests Lukas Czerner
2011-09-16 3:56 ` Ted Ts'o
2011-09-01 8:39 ` [PATCH 1/5 v2] e2fsprogs: create open() and stat() helpers Lukas Czerner
2011-09-16 3:50 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110916035331.GU28181@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).