From: "Darrick J. Wong" <djwong@us.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH 1/2] libext2fs: add metadata checksum and snapshot feature flags
Date: Mon, 19 Sep 2011 11:58:31 -0700 [thread overview]
Message-ID: <20110919185831.GI12086@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <1316127052-1890-2-git-send-email-tytso@mit.edu>
On Thu, Sep 15, 2011 at 06:50:51PM -0400, Theodore Ts'o wrote:
<snip>
> diff --git a/lib/ext2fs/ext2_fs.h b/lib/ext2fs/ext2_fs.h
> index 4fec5db..1c86cb2 100644
> --- a/lib/ext2fs/ext2_fs.h
> +++ b/lib/ext2fs/ext2_fs.h
> @@ -363,7 +370,8 @@ struct ext2_inode {
> __u16 l_i_file_acl_high;
> __u16 l_i_uid_high; /* these 2 fields */
> __u16 l_i_gid_high; /* were reserved2[0] */
> - __u32 l_i_reserved2;
> + __u16 l_i_checksum_lo; /* crc32c(uuid+inum+inode) */
> + __u16 l_i_reserved; /* crc32c(uuid+inum+inode) */
> } linux2;
> struct {
> __u8 h_i_frag; /* Fragment number */
> @@ -410,7 +418,8 @@ struct ext2_inode_large {
> __u16 l_i_file_acl_high;
> __u16 l_i_uid_high; /* these 2 fields */
> __u16 l_i_gid_high; /* were reserved2[0] */
> - __u32 l_i_reserved2;
> + __u16 l_i_checksum_lo; /* crc32c(uuid+inum+inode) */
> + __u16 l_i_reserved;
> } linux2;
> struct {
> __u8 h_i_frag; /* Fragment number */
> @@ -422,7 +431,7 @@ struct ext2_inode_large {
> } hurd2;
> } osd2; /* OS dependent 2 */
> __u16 i_extra_isize;
> - __u16 i_pad1;
> + __u16 i_checksum_hi; /* crc32c(uuid+inum+inode) */
> __u32 i_ctime_extra; /* extra Change time (nsec << 2 | epoch) */
> __u32 i_mtime_extra; /* extra Modification time (nsec << 2 | epoch) */
> __u32 i_atime_extra; /* extra Access time (nsec << 2 | epoch) */
> @@ -441,7 +450,7 @@ struct ext2_inode_large {
> #define i_gid_low i_gid
> #define i_uid_high osd2.linux2.l_i_uid_high
> #define i_gid_high osd2.linux2.l_i_gid_high
> -#define i_reserved2 osd2.linux2.l_i_reserved2
> +#define i_checksum osd2.linux2.l_i_checksum
s/i_checksum/i_checksum_lo/, I think.
--D
next prev parent reply other threads:[~2011-09-19 18:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 22:50 [PATCH 0/2] On disk format changes - V3 Theodore Ts'o
2011-09-15 22:50 ` [PATCH 1/2] libext2fs: add metadata checksum and snapshot feature flags Theodore Ts'o
2011-09-15 23:09 ` Andreas Dilger
2011-09-15 23:11 ` Ted Ts'o
2011-09-15 23:34 ` Andreas Dilger
2011-09-15 23:41 ` Ted Ts'o
2011-09-16 0:09 ` Andreas Dilger
2011-09-16 0:56 ` Darrick J. Wong
2011-09-16 4:03 ` Andreas Dilger
2011-09-16 1:06 ` Ted Ts'o
2011-09-16 3:57 ` Andreas Dilger
2011-09-16 14:28 ` Ted Ts'o
2011-09-19 18:58 ` Darrick J. Wong [this message]
2011-09-20 18:56 ` Darrick J. Wong
2011-09-21 8:03 ` Amir Goldstein
2011-09-21 20:40 ` Darrick J. Wong
2011-09-22 2:12 ` Amir Goldstein
2011-09-22 19:18 ` Darrick J. Wong
2011-09-23 5:57 ` Amir Goldstein
2011-09-15 22:50 ` [PATCH 2/2] debugfs: add 64-bit support to the set_field commands Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919185831.GI12086@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=amir73il@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).