From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/4] tune2fs: kill external journal if device not found
Date: Mon, 26 Sep 2011 13:59:10 -0400 [thread overview]
Message-ID: <20110926175910.GA3282@thunk.org> (raw)
In-Reply-To: <1316821124-7461-2-git-send-email-adilger@whamcloud.com>
On Fri, Sep 23, 2011 at 05:38:42PM -0600, Andreas Dilger wrote:
> Continue to remove the external journal device even if the device
> cannot be found.
>
> Add a test to verify that the journal device/UUID are actually removed
> from the superblock. It isn't possible to use a real journal device
> for testing without loopback devices and such (it must be a block device)
> and this would invite complexity and failures in the regression test.
>
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
I've taken care of it this time, but please don't include whitespace
changes in patches. It makes it a lot harder to review them in
e-mail. Thanks!!
- Ted
next prev parent reply other threads:[~2011-09-26 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 23:38 [PATCH 1/4] misc: quiet minor compiler errors Andreas Dilger
2011-09-23 23:38 ` [PATCH 2/4] tune2fs: kill external journal if device not found Andreas Dilger
2011-09-24 18:49 ` Ted Ts'o
2011-09-26 17:59 ` Ted Ts'o [this message]
2011-09-23 23:38 ` [PATCH 3/4] ext2fs: add multi-mount protection (INCOMPAT_MMP) Andreas Dilger
2011-09-24 18:49 ` Ted Ts'o
2011-09-23 23:38 ` [PATCH 4/4] e2fsck: regression tests for INCOMPAT_MMP feature Andreas Dilger
2011-09-23 23:51 ` Andreas Dilger
2011-09-24 18:51 ` Ted Ts'o
2011-09-25 6:04 ` Andreas Dilger
2011-09-25 12:05 ` Ted Ts'o
2011-09-23 23:44 ` [PATCH 1/4] misc: quiet minor compiler errors Andreas Dilger
2011-09-24 18:49 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926175910.GA3282@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).