From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Joakim Tjernlund <joakim.tjernlund@transmode.se>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Mingming Cao <cmm@us.ibm.com>, David Miller <davem@davemloft.net>,
linux-crypto <linux-crypto@vger.kernel.org>,
linux-ext4@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Bob Pearson <rpearson@systemfabricworks.com>,
Theodore Tso <tytso@mit.edu>
Subject: Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm
Date: Mon, 3 Oct 2011 17:55:10 -0700 [thread overview]
Message-ID: <20111004005510.GB12447@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20111003203513.GA10346@gondor.apana.org.au>
On Mon, Oct 03, 2011 at 09:35:13PM +0100, Herbert Xu wrote:
> On Mon, Oct 03, 2011 at 10:27:03PM +0200, Joakim Tjernlund wrote:
> >
> > > > Start from Bobs latest patches and add crc32c to lib/crc32.c
> > >
> > > If I did that, how should I handle patching in the hardware accelerated version
> > > on Intel systems? That switcheroo ability seems to have been Herbert Xu's
> > > motivation for moving crc32c into crypto/ in the first place:
> >
> > I don't know, I haven't looked at that problem. I suspect it moved because that
> > was the easiest solution. Having an identical impl. of crc32(only the table values differ)
> > in crypto compared to the one in lib is not the way forward though.
>
> You can always get crypto/crc32c.c to use call helpers from
> lib/crc32.c.
So what I think I'm hearing is...
1. Apply Bob's slice-by-8 algorithm patch to regular crc32.
2. Adapt crc32's build code to generate crc32c as well.
3. Remove crypto/crc32c.c's implementation and have it wrap the code generated
by #2.
4. Retain the current libcrc32c. I guess if you don't configure CRYPTO and
CRYPTO_CRC32C then it could also just reference the generated crc32c functions
directly.
Is this a satisfactory way to move forward?
--D
next prev parent reply other threads:[~2011-10-04 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 19:29 [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm Darrick J. Wong
2011-10-01 14:02 ` Joakim Tjernlund
2011-10-03 15:36 ` Darrick J. Wong
2011-10-03 20:27 ` Joakim Tjernlund
2011-10-03 20:35 ` Herbert Xu
2011-10-04 0:55 ` Darrick J. Wong [this message]
2011-10-04 6:59 ` Herbert Xu
2011-10-04 23:54 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004005510.GB12447@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmm@us.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpearson@systemfabricworks.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).