From: Jan Kara <jack@suse.cz>
To: Ted Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, Tao Ma <tm@tao.ma>,
linux-ext4@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ext3: Remove the obsolete broken EXT3_IOC32_WAIT_FOR_READONLY.
Date: Mon, 10 Oct 2011 18:27:00 +0200 [thread overview]
Message-ID: <20111010162700.GG3944@quack.suse.cz> (raw)
In-Reply-To: <20111008205235.GL7948@thunk.org>
On Sat 08-10-11 16:52:35, Ted Tso wrote:
> On Sat, Oct 08, 2011 at 12:12:33AM +0200, Jan Kara wrote:
> > On Fri 07-10-11 23:21:18, Tao Ma wrote:
> > > From: Tao Ma <boyu.mt@taobao.com>
> > >
> > > There are no user of EXT3_IOC32_WAIT_FOR_READONLY and also it is
> > > broken. No one set the set_ro_timer, no one wake up us and our
> > > state is set to TASK_INTERRUPTIBLE not RUNNING. So remove it.
> > Hmm, I vaguely recall Andrew had some debugging patches which were using
> > turn_ro_timer and this functionality. But I'm not sure if they are still
> > usable or if they still make sense when one can easily test crashing using
> > virtual machines... Andrew?
>
> That's why I decided to accept the corresponding patch for ext4; if
> the rest of debugging patch is out-of-tree, then might as well have it
> all out-of-tree --- and killall qemu is probably a better way of
> testing this anyway.
OK. I've merged the patch in my tree. If Andrew shouts loudly, I can
always revert it :)
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2011-10-10 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 15:21 [PATCH] ext3: Remove the obsolete broken EXT3_IOC32_WAIT_FOR_READONLY Tao Ma
2011-10-07 22:12 ` Jan Kara
2011-10-08 20:52 ` Ted Ts'o
2011-10-10 16:27 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010162700.GG3944@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox