* [PATCH] ext4/fsync.c: functions should not be declared extern
@ 2011-09-23 22:14 H Hartley Sweeten
2011-10-12 3:09 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 22:14 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-ext4, tytso, adilger.kernel
The function declaration in ext4.h is already marked extern. The function
definition should not have the tag.
This quiets the sparse noise:
warning: function 'ext4_flush_completed_IO' with external linkage has definition
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
---
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 036f78f..c942924 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -75,7 +75,7 @@ static void dump_completed_IO(struct inode * inode)
* to written.
* The function return the number of pending IOs on success.
*/
-extern int ext4_flush_completed_IO(struct inode *inode)
+int ext4_flush_completed_IO(struct inode *inode)
{
ext4_io_end_t *io;
struct ext4_inode_info *ei = EXT4_I(inode);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-12 3:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 22:14 [PATCH] ext4/fsync.c: functions should not be declared extern H Hartley Sweeten
2011-10-12 3:09 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).