* [PATCH] ext4/extents.c: quiet sparse noise about plain integer as NULL pointer
@ 2011-09-23 22:32 H Hartley Sweeten
2011-10-12 3:11 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 22:32 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-ext4, tytso, adilger.kernel
The third parameter to ext4_free_blocks is a struct buffer_head *. This
parameter should be NULL not 0.
This quiets the sparse noise:
warning: Using plain integer as NULL pointer
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
---
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 57cf568..97e8d2b 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2238,7 +2238,7 @@ static int ext4_remove_blocks(handle_t *handle, struct inode *inode,
start = ext4_ext_pblock(ex);
ext_debug("free first %u blocks starting %llu\n", num, start);
- ext4_free_blocks(handle, inode, 0, start, num, flags);
+ ext4_free_blocks(handle, inode, NULL, start, num, flags);
} else {
printk(KERN_INFO "strange request: removal(2) "
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4/extents.c: quiet sparse noise about plain integer as NULL pointer
2011-09-23 22:32 [PATCH] ext4/extents.c: quiet sparse noise about plain integer as NULL pointer H Hartley Sweeten
@ 2011-10-12 3:11 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-10-12 3:11 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-ext4, adilger.kernel
On Fri, Sep 23, 2011 at 03:32:44PM -0700, H Hartley Sweeten wrote:
> The third parameter to ext4_free_blocks is a struct buffer_head *. This
> parameter should be NULL not 0.
>
> This quiets the sparse noise:
>
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-12 3:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 22:32 [PATCH] ext4/extents.c: quiet sparse noise about plain integer as NULL pointer H Hartley Sweeten
2011-10-12 3:11 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).