linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Check extent overflow with the right range.
Date: Tue, 18 Oct 2011 11:07:45 -0400	[thread overview]
Message-ID: <20111018150745.GA17025@thunk.org> (raw)
In-Reply-To: <4E9CE414.9040706@tao.ma>

On Tue, Oct 18, 2011 at 10:27:32AM +0800, Tao Ma wrote:
> We have met with some corruption, but not sure whether it is related to
> this or not. To be honest, we went through the code and find that this
> may be a possible cause. So if you think it could never happen, we are
> OK to drop this patch.

I have no problem adding sanity checks; it makes for more robust code.
I just wanted to make sure there wasn't a real bug hiding somewhere
that wasn't getting addressed.

Thanks,

					- Ted

  reply	other threads:[~2011-10-18 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17  6:57 corruption on 3.1.0-rc9-next-20111011+ Dan Carpenter
2011-10-17  8:10 ` Dan Carpenter
2011-10-17  8:45   ` [PATCH] ext4: Check extent overflow with the right range Tao Ma
2011-10-17  9:10     ` Yongqiang Yang
2011-10-17 14:16     ` Ted Ts'o
2011-10-18  2:27       ` Tao Ma
2011-10-18 15:07         ` Ted Ts'o [this message]
2011-10-17  8:51   ` corruption on 3.1.0-rc9-next-20111011+ Tao Ma
2011-10-17  9:08     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111018150745.GA17025@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tm@tao.ma \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).