From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext3: Allow quota file use root reservation
Date: Fri, 21 Oct 2011 01:36:21 +0200 [thread overview]
Message-ID: <20111020233621.GH20542@quack.suse.cz> (raw)
In-Reply-To: <1319019383-12603-2-git-send-email-dmonakhov@openvz.org>
On Wed 19-10-11 14:16:23, Dmitry Monakhov wrote:
> Quota file is fs's metadata, so it is reasonable to permit use
> root resevation if necessary. This patch fix 265'th xfstest failure
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> fs/ext3/balloc.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 6386d76..5430559 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
...
> @@ -1546,7 +1546,7 @@ ext3_fsblk_t ext3_new_blocks(handle_t *handle, struct inode *inode,
> if (block_i && ((windowsz = block_i->rsv_window_node.rsv_goal_size) > 0))
> my_rsv = &block_i->rsv_window_node;
>
> - if (!ext3_has_free_blocks(sbi)) {
> + if (!ext3_has_free_blocks(sbi, IS_NOQUOTA(inode))) {
> *errp = -ENOSPC;
> goto out;
> }
Hmph, using IS_NOQUOTA() for a detection of quota files is a hack. But if
we look at it like "if a file is extempted from quota, it can be as well
allowed to use reserved blocks" then it makes some sense. So I'll take the
patch. Thanks.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-10-20 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 10:16 [PATCH 1/2] ext4: Allow quota file use root reservation Dmitry Monakhov
2011-10-19 10:16 ` [PATCH 2/2] ext3: " Dmitry Monakhov
2011-10-20 23:36 ` Jan Kara [this message]
2011-10-21 0:11 ` [PATCH 1/2] ext4: " Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020233621.GH20542@quack.suse.cz \
--to=jack@suse.cz \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).