From: Ted Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, achender@linux.vnet.ibm.com
Subject: Re: [PATCH 1/6] ext4: cleanup ext4_ext_grow_indepth code
Date: Sat, 22 Oct 2011 01:27:26 -0400 [thread overview]
Message-ID: <20111022052726.GE4196@thunk.org> (raw)
In-Reply-To: <1319144939-28801-2-git-send-email-dmonakhov@openvz.org>
On Fri, Oct 21, 2011 at 01:08:54AM +0400, Dmitry Monakhov wrote:
> Currently code make an impression what grow procedure is very complicated
> and some mythical paths, blocks are involved. But in fact grow in depth
> it relatively simple procedure:
> 1) Just create new meta block and copy roots content to it
> 2) Convert root from extent to index if old depth == 0
> 3) update root block pointer
>
Applied, thanks.
BTW:
> - Do not pass path parameter to new_meta_block() in order to
> provoke allocation from inode's group because top-level block
> should site closer to it's inode, but not to leaf data block.
This happens anyway, due to logic in mballoc; as a result the path
parameter in ext4_ext_new_meta_block() is really pointless, and should
be dropped.
- Ted
next prev parent reply other threads:[~2011-10-22 7:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 21:08 [PATCH 0/6] ext4: cleanups and regression fixes for grow/shrink logic V2 Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 1/6] ext4: cleanup ext4_ext_grow_indepth code Dmitry Monakhov
2011-10-22 5:27 ` Ted Ts'o [this message]
2011-10-20 21:08 ` [PATCH 2/6] ext4: move inode indepth shrink logic to didicated function Dmitry Monakhov
2011-10-25 8:01 ` Ted Ts'o
2011-10-28 10:47 ` Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 3/6] ext4: Do not clear EOFBLOCKS_FL too soon Dmitry Monakhov
2011-10-25 8:18 ` Ted Ts'o
2011-10-25 11:57 ` Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 4/6] ext4: remove messy logic from ext4_ext_rm_leaf Dmitry Monakhov
2011-10-25 11:44 ` Ted Ts'o
2011-10-20 21:08 ` [PATCH 5/6] ext4: fix punch_hole extend handler Dmitry Monakhov
2011-10-25 12:05 ` Ted Ts'o
2011-10-25 12:35 ` Dmitry Monakhov
2011-10-26 13:38 ` Ted Ts'o
2011-10-20 21:08 ` [PATCH 6/6] ext4: update EOFBLOCKS flag on fallocate properly Dmitry Monakhov
2011-10-25 12:22 ` Ted Ts'o
2011-10-28 21:40 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111022052726.GE4196@thunk.org \
--to=tytso@mit.edu \
--cc=achender@linux.vnet.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).