From: Ted Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, achender@linux.vnet.ibm.com
Subject: Re: [PATCH 5/6] ext4: fix punch_hole extend handler
Date: Wed, 26 Oct 2011 09:38:01 -0400 [thread overview]
Message-ID: <20111026133801.GX31921@thunk.org> (raw)
In-Reply-To: <87fwihi6zi.fsf@dmbot.sw.ru>
On Tue, Oct 25, 2011 at 04:35:45PM +0400, Dmitry Monakhov wrote:
> BTW can you please highlight your plans to make libquota in to working
> shape, right now it simply rewrites old quota file so fsck each time
> result int fs modifications. I have some patches in my queue which add
> quota check capabilities in libquota/e2fsck.
I've requested that Aditya make changes to libquota so it doesn't
always rewrite the quota file at each fsck; I consider this a bug.
Unfortunately he hasn't had a chance to get to this yet. If you have
patches which implement part of this, please feel free to submit your
patches.
I don't believe libquota is going to make sense the way it is
currently written to be an exported library. It's very tightly
dependent on ext2fs, and it's not clear it would be useful to external
programs. It would require major changes to the API so it could be
useful for other file systems. Given that there are some other file
systems (like ocfs2) which are using the quota formats as internal
file, perhaps it would be worthwhile to abstract away the ext2fs
specific functionality. But I'm not entirely convinced, and perhaps
we will just rename libquota to libinternal, assume that it will
always be built statically, and then move things like profile.c into
libinternal.a.
- Ted
next prev parent reply other threads:[~2011-10-26 13:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 21:08 [PATCH 0/6] ext4: cleanups and regression fixes for grow/shrink logic V2 Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 1/6] ext4: cleanup ext4_ext_grow_indepth code Dmitry Monakhov
2011-10-22 5:27 ` Ted Ts'o
2011-10-20 21:08 ` [PATCH 2/6] ext4: move inode indepth shrink logic to didicated function Dmitry Monakhov
2011-10-25 8:01 ` Ted Ts'o
2011-10-28 10:47 ` Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 3/6] ext4: Do not clear EOFBLOCKS_FL too soon Dmitry Monakhov
2011-10-25 8:18 ` Ted Ts'o
2011-10-25 11:57 ` Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 4/6] ext4: remove messy logic from ext4_ext_rm_leaf Dmitry Monakhov
2011-10-25 11:44 ` Ted Ts'o
2011-10-20 21:08 ` [PATCH 5/6] ext4: fix punch_hole extend handler Dmitry Monakhov
2011-10-25 12:05 ` Ted Ts'o
2011-10-25 12:35 ` Dmitry Monakhov
2011-10-26 13:38 ` Ted Ts'o [this message]
2011-10-20 21:08 ` [PATCH 6/6] ext4: update EOFBLOCKS flag on fallocate properly Dmitry Monakhov
2011-10-25 12:22 ` Ted Ts'o
2011-10-28 21:40 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026133801.GX31921@thunk.org \
--to=tytso@mit.edu \
--cc=achender@linux.vnet.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).