From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: fs: jdb/jbd2: Put identical code in a common header
Date: Thu, 27 Oct 2011 05:13:30 -0400 [thread overview]
Message-ID: <20111027091330.GA31921@thunk.org> (raw)
In-Reply-To: <20111018204031.GE4599@quack.suse.cz>
On Tue, Oct 18, 2011 at 10:40:31PM +0200, Jan Kara wrote:
> On Wed 05-10-11 13:29:29, Thomas Gleixner wrote:
> > The state bits and the lock functions of jbd and jbd2 are
> > identical. Share them.
> Hum, Ted, I don't think this got picked up. What's your opinion?
It seems reasonable to me. Factoring out common code is a good
though, although inline functions won't save any text space and since
this part of the jbd header files are rarely changed, so the
maintainability advantages are reduced.
I'll take the patch and include it in the ext4 tree.
- Ted
prev parent reply other threads:[~2011-10-27 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 11:29 fs: jdb/jbd2: Put identical code in a common header Thomas Gleixner
2011-10-18 20:40 ` Jan Kara
2011-10-27 9:13 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027091330.GA31921@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).