From: Ted Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [PATCH 1/3] ext4: migrate cleanup
Date: Sat, 29 Oct 2011 08:31:38 -0400 [thread overview]
Message-ID: <20111029123138.GB19536@thunk.org> (raw)
In-Reply-To: <1316266379-18737-1-git-send-email-dmonakhov@openvz.org>
On Sat, Sep 17, 2011 at 05:32:57PM +0400, Dmitry Monakhov wrote:
> This patch cleanup code a bit, actual logic not changed
> - Move current block pointer to migrate_structure, let's all
> walk info will be in one structure.
> - Get rid of usless null ind-block ptr checks, caller already
> does that check.
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Applied, with one fixup:
> @@ -211,17 +184,15 @@ static int update_tind_extent_range(handle_t *handle, struct inode *inode,
> i_data = (__le32 *)bh->b_data;
> for (i = 0; i < max_entries; i++) {
> if (i_data[i]) {
> - retval = update_dind_extent_range(handle, inode,
> - le32_to_cpu(i_data[i]),
> - &blk_count, lb);
> + retval = update_ind_extent_range(handle, inode,
> + le32_to_cpu(i_data[i]), lb);
Surely this should remain a call to update_dind_extent_range(); I
assume it was a cut-and-paste editing error.
- Ted
prev parent reply other threads:[~2011-10-29 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-17 13:32 [PATCH 1/3] ext4: migrate cleanup Dmitry Monakhov
2011-09-17 13:32 ` [PATCH 2/3] ext4: fix quota accounting during migration Dmitry Monakhov
2011-10-29 13:09 ` Ted Ts'o
2011-09-17 13:32 ` [PATCH 3/3] ext4: fix block swap procedure on migration V2 Dmitry Monakhov
2011-09-19 16:29 ` Andreas Dilger
2011-09-19 16:45 ` Dmitry Monakhov
2011-10-29 12:54 ` Ted Ts'o
2011-10-28 20:34 ` Ping Dmitry Monakhov
2011-10-29 12:31 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029123138.GB19536@thunk.org \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).