[PATCH 1/2] ext4: remove redundant argument in mb_find_extent()

[PATCH 1/2] ext4: remove redundant argument in mb_find_extent()

[Robin Dong]

From: Ronbin Dong <sanbai@taobao.com>

The argument of "ord" in mb_find_extent is not necessary anymore.

Signed-off-by: Robin Dong <sanbai@taobao.com>
---
 fs/ext4/mballoc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 17a5a57..0702627 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1432,9 +1432,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
 		if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
 			break;
 
-		ord = mb_find_order_for_block(e4b, next);
+		order = mb_find_order_for_block(e4b, next);
 
-		order = ord;
 		block = next >> order;
 		ex->fe_len += 1 << order;
 	}
-- 
1.7.4.1

[PATCH 2/2] ext4: fix a typo in struct ext4_allocation_context

[Robin Dong]

From: Robin Dong <sanbai@taobao.com>

This patch change "bext" to "best".

Signed-off-by: Robin Dong <sanbai@taobao.com>
---
 fs/ext4/mballoc.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index 9d4a636..86a880b 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -175,7 +175,7 @@ struct ext4_allocation_context {
 	/* the best found extent */
 	struct ext4_free_extent ac_b_ex;
 
-	/* copy of the bext found extent taken before preallocation efforts */
+	/* copy of the best found extent taken before preallocation efforts */
 	struct ext4_free_extent ac_f_ex;
 
 	/* number of iterations done. we have to track to limit searching */
-- 
1.7.4.1

Re: [PATCH 1/2] ext4: remove redundant argument in mb_find_extent()

[Andreas Dilger]

On 2011-08-25, at 5:36 AM, Robin Dong wrote:
> From: Ronbin Dong <sanbai@taobao.com>
> 
> The argument of "ord" in mb_find_extent is not necessary anymore.
> 
> Signed-off-by: Robin Dong <sanbai@taobao.com>
> ---
> fs/ext4/mballoc.c |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)

This patch doesn't remove the declaration "int ord;" at the start of the function.

> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 17a5a57..0702627 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1432,9 +1432,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
> 		if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
> 			break;
> 
> -		ord = mb_find_order_for_block(e4b, next);
> +		order = mb_find_order_for_block(e4b, next);
> 
> -		order = ord;
> 		block = next >> order;
> 		ex->fe_len += 1 << order;
> 	}
> -- 
> 1.7.4.1

Cheers, Andreas

Re: [PATCH 2/2] ext4: fix a typo in struct ext4_allocation_context

[Ted Ts'o]

On Thu, Aug 25, 2011 at 07:36:32PM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
> 
> This patch change "bext" to "best".
> 
> Signed-off-by: Robin Dong <sanbai@taobao.com>

Thanks, applied.

						- Ted