From: Jan Kara <jack@suse.cz>
To: Ted Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, Eryu Guan <guaneryu@gmail.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext3: Avoid creating new file in append-only dir when open(2) return error
Date: Wed, 2 Nov 2011 15:23:15 +0100 [thread overview]
Message-ID: <20111102142315.GA31575@quack.suse.cz> (raw)
In-Reply-To: <20111101232725.GO32161@thunk.org>
On Tue 01-11-11 19:27:25, Ted Tso wrote:
> On Wed, Nov 02, 2011 at 12:10:34AM +0100, Jan Kara wrote:
> > >
> > > To avoid this, check EXT3_APPEND_FL flag first in ext3_create before
> > > really allocating new inode.
> > Yes, it is nicer to not create any file when open(2) fails in the end.
> > BTW, how have you spotted this? I've taken your ext2 and ext3 patches into
> > my tree.
>
> Note: I have a fix in my tree which removes EXTx_APPEND_FL from the
> set of flags that can be inherited from the containing directory in
> ext2, ext3, and ext4. That addresses this issue without needing to
> make the change in this patch.
Ah, OK. I forgot about it. I've removed the two patches from my queue.
Thanks for letting me know.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-11-02 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 18:03 [PATCH] ext3: Avoid creating new file in append-only dir when open(2) return error Eryu Guan
2011-11-01 23:10 ` Jan Kara
2011-11-01 23:27 ` Ted Ts'o
2011-11-02 14:23 ` Jan Kara [this message]
2011-11-02 2:05 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102142315.GA31575@quack.suse.cz \
--to=jack@suse.cz \
--cc=guaneryu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).