From: Ted Ts'o <tytso@mit.edu>
To: Robin Dong <hao.bigrat@gmail.com>
Cc: linux-ext4@vger.kernel.org, Robin Dong <sanbai@taobao.com>
Subject: Re: [PATCH] e2fsprogs: fix "Illegal block number" for scan_block_bitmap()
Date: Fri, 11 Nov 2011 21:16:13 -0500 [thread overview]
Message-ID: <20111112021613.GG4055@thunk.org> (raw)
In-Reply-To: <1320927324-3613-1-git-send-email-hao.bigrat@gmail.com>
On Thu, Nov 10, 2011 at 08:15:24PM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
>
> After:
> # mke2fs -O ^has_journal,^resize_inode,^uninit_bg,extent,meta_bg,flex_bg,bigalloc /dev/sda
> # e2freefrag /dev/sda
>
> It will report error message like:
>
> Illegal block number passed to ext2fs_test_block_bitmap #1732133 for block bitmap for /dev/sda
> Illegal block number passed to ext2fs_test_block_bitmap #1732134 for block bitmap for /dev/sda
> Illegal block number passed to ext2fs_test_block_bitmap #1732135 for block bitmap for /dev/sda
>
> One bit in bitmap of bigalloc-ext4 means a cluster not a block, therefore ext2fs_fast_test_block_bitmap2
> should check cluster.
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2011-11-12 5:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 12:15 [PATCH] e2fsprogs: fix "Illegal block number" for scan_block_bitmap() Robin Dong
2011-11-12 2:16 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111112021613.GG4055@thunk.org \
--to=tytso@mit.edu \
--cc=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sanbai@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).