From: Ted Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: debugfs: Fix sprintf stack overflow
Date: Sun, 20 Nov 2011 15:47:58 -0500 [thread overview]
Message-ID: <20111120204758.GA14791@thunk.org> (raw)
In-Reply-To: <20111012010221.GN12447@tux1.beaverton.ibm.com>
On Tue, Oct 11, 2011 at 03:02:21PM -0000, Darrick J. Wong wrote:
> The htree dump code overflows a char buffer if the directory has a long
> filename because the buffer is not large enough to hold the characters that are
> not part of the filename. Make the buffer larger and use snprintf instead.
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2011-11-20 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 1:02 [PATCH] debugfs: Fix sprintf stack overflow Darrick J. Wong
2011-10-12 2:38 ` Eric Sandeen
2011-11-20 20:47 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111120204758.GA14791@thunk.org \
--to=tytso@mit.edu \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).