From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>, stable@kernel.org
Subject: Re: [PATCH] ext4: fix race condition when loading block or inode bitmaps
Date: Fri, 25 Nov 2011 11:19:42 -0500 [thread overview]
Message-ID: <20111125161942.GF5167@thunk.org> (raw)
In-Reply-To: <4ECEFECE.2050900@tao.ma>
On Fri, Nov 25, 2011 at 10:34:54AM +0800, Tao Ma wrote:
> Sorry, but I don't get your meaning here.
> In bitmap_uptodate, we check both the flag of BH_uptodate and
> BH_BITMAP_UPTODATE. And in your patch below, we just move the set of
> bitmap_uptodate after bh_uptodate. So I don't think the above scenario
> would ever happen. Could you please explain it in more detail?
Yes, you're right. I didn't realize bitmap_uptodate() checked both
bits. I had assumed it used the same convention as the other
functions that set/git bits in bh_state.
Rats, and I thought I had finally nailed the bug...
- Ted
next prev parent reply other threads:[~2011-11-25 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 1:08 [PATCH] ext4: fix race condition when loading block or inode bitmaps Theodore Ts'o
2011-11-25 2:34 ` Tao Ma
2011-11-25 16:19 ` Ted Ts'o [this message]
2011-11-25 3:41 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111125161942.GF5167@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox