From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>,
Theodore Tso <tytso@mit.edu>,
Joakim Tjernlund <joakim.tjernlund@transmode.se>,
Bob Pearson <rpearson@systemfabricworks.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-crypto <linux-crypto@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Mingming Cao <cmm@us.ibm.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH v5.1 00/14] crc32c: Add faster algorithm and self-test code
Date: Thu, 1 Dec 2011 12:12:37 -0800 [thread overview]
Message-ID: <20111201201237.GB23175@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20111130142911.673c2d99.akpm@linux-foundation.org>
On Wed, Nov 30, 2011 at 02:29:11PM -0800, Andrew Morton wrote:
> On Mon, 28 Nov 2011 14:36:59 -0800
> "Darrick J. Wong" <djwong@us.ibm.com> wrote:
>
> > This patchset (re)uses Bob Pearson's crc32 slice-by-8 code to stamp out a
> > software crc32c implementation.
>
> I think the attributions here are all messed up. As the patches stand,
> it appears that you wrote all of them. But I don't think that is the
> case.
>
> If Bob wrote a particular patch then that patch should be sent with a
> From: Bob Pearson <rpearson@systemfabricworks.com> right at the start
> of the changelog so that he is recorded as the primary author. If the
> email sender (ie: you) was the primary author then this attribution can
> be omitted and we fall back to using the From: from the email headers.
>
> Also, every one of these patches should have you own signed-off-by,
> regardless of its authorship. For reasons explained in
> Documentation/SubmittingPatches, section 12.
>
> Please fix these things up and resend.
>
> Also, it would be conventional and useful if each patch title was
> prefixed by its subsystem identifier. ie, "removed two instances of
> trailing whitespaces" should be titled "crc32: remove two instances of
> trailing whitespace" or "lib/crc32.c: remove two instances of trailing
> whitespaces".
Okay, I'll massage the changelogs to give them more descriptive subjects, and
fix the attribution chain. Thank you for the feedback.
--D
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2011-12-01 20:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 22:36 [PATCH v5.1 00/14] crc32c: Add faster algorithm and self-test code Darrick J. Wong
2011-11-28 22:37 ` [PATCH 01/14] removed two instances of trailing whitespaces Darrick J. Wong
2011-11-28 22:37 ` [PATCH 02/14] Moved a long comment from lib/crc32.c to Documentation/crc32.txt Darrick J. Wong
2011-11-28 22:37 ` [PATCH 03/14] Replaced the unit test provided in crc32.c, which doesn't have a Darrick J. Wong
2011-11-28 22:37 ` [PATCH 04/14] Replace 2D array references by pointer references in loops Darrick J. Wong
2011-11-28 22:37 ` [PATCH 05/14] Misc cleanup of lib/crc32.c and related files Darrick J. Wong
2011-11-28 22:37 ` [PATCH 06/14] crc32.c in its original version freely mixed u32, __le32 and __be32 types Darrick J. Wong
2011-11-28 22:37 ` [PATCH 07/14] crc32.c provides a choice of one of several algorithms for Darrick J. Wong
2011-11-28 22:37 ` [PATCH 08/14] add slicing-by-8 algorithm to the existing Darrick J. Wong
2011-11-28 22:38 ` [PATCH 09/14] Add two changes that improve the performance of x86 systems Darrick J. Wong
2011-11-28 22:38 ` [PATCH 10/14] Some final changes Darrick J. Wong
2011-11-28 22:38 ` [PATCH 11/14] crc32: Bolt on crc32c Darrick J. Wong
2011-11-28 22:38 ` [PATCH 12/14] crypto: crc32c should use library implementation Darrick J. Wong
2011-11-28 22:38 ` [PATCH 13/14] crc32: Add self-test code for crc32c Darrick J. Wong
2011-11-28 22:38 ` [PATCH 14/14] crc32: Select an algorithm via kconfig Darrick J. Wong
2011-11-30 22:29 ` [PATCH v5.1 00/14] crc32c: Add faster algorithm and self-test code Andrew Morton
2011-12-01 20:12 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201201237.GB23175@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=herbert@gondor.hengli.com.au \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpearson@systemfabricworks.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).