From: Ted Ts'o <tytso@mit.edu>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-ext4@vger.kernel.org, Dmitry Monakhov <dmonakhov@openvz.org>
Subject: Re: [PATCH] ext4: Fix crash due to getting bogus eh_depth value
Date: Mon, 12 Dec 2011 11:00:40 -0500 [thread overview]
Message-ID: <20111212160040.GB4243@thunk.org> (raw)
In-Reply-To: <20111212104952.GA14659@bloggs.ozlabs.ibm.com>
On Mon, Dec 12, 2011 at 09:49:52PM +1100, Paul Mackerras wrote:
> Commit 1939dd84b3 ("ext4: cleanup ext4_ext_grow_indepth code") added a
> reference to ext4_extent_header.eh_depth, but forget to pass the value
> read through le16_to_cpu. The result is a crash on big-endian
> machines, such as this crash on a POWER7 server:
Thanks for finding this! While I was driving to work I had started
thinking that 0x0101 was a very suspicious number, and I was thinking
that it might have been a missing byte swap somewhere.
I'll get this pushed to Linus ASAP as a regression fix.
- Ted
prev parent reply other threads:[~2011-12-12 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 10:49 [PATCH] ext4: Fix crash due to getting bogus eh_depth value Paul Mackerras
2011-12-12 16:00 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212160040.GB4243@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).