From: Andrea Arcangeli <aarcange@redhat.com>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/2] ext4: avoid hangs in ext4_da_should_update_i_disksize()
Date: Mon, 12 Dec 2011 17:57:59 +0100 [thread overview]
Message-ID: <20111212165758.GF16411@redhat.com> (raw)
In-Reply-To: <CAGBYx2Y3WUc1m0BvTyrDcEyh0TTeLriWGA3YjgKcGoW=s8PYnw@mail.gmail.com>
On Mon, Dec 12, 2011 at 11:28:21AM +0800, Yongqiang Yang wrote:
> Hi Andrea,
>
> I can not figure out why ext4 hangs. Could you explain more on hanging?
Well I tried to explain it in the changeset comment.
If "copied" is zero, end/offset/idx becomes -1, and this loops:
for (i = 0; i < idx; i++)
definitely a bug and checking ext4 git I don't see anything fixing it.
next prev parent reply other threads:[~2011-12-12 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 2:27 ext4_da_write_end() and copied == 0 Andrea Arcangeli
2011-12-12 2:27 ` [PATCH 1/2] ext4: avoid hangs in ext4_da_should_update_i_disksize() Andrea Arcangeli
2011-12-12 3:28 ` Yongqiang Yang
2011-12-12 16:57 ` Andrea Arcangeli [this message]
2011-12-13 1:05 ` Yongqiang Yang
2011-12-12 20:27 ` Jan Kara
2011-12-14 2:44 ` Ted Ts'o
2011-12-12 2:27 ` [PATCH 2/2] ext4: ext4_discard_partial_page_buffers_no_lock() wrong parameters Andrea Arcangeli
2011-12-12 3:17 ` Yongqiang Yang
2011-12-12 16:55 ` Andrea Arcangeli
2011-12-12 20:07 ` Allison Henderson
2011-12-13 0:40 ` Andrea Arcangeli
2011-12-13 1:16 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212165758.GF16411@redhat.com \
--to=aarcange@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).