From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] jbd2: clear revoked flag on buffers before a new transaction started
Date: Wed, 28 Dec 2011 18:31:02 -0500 [thread overview]
Message-ID: <20111228233102.GF12370@thunk.org> (raw)
In-Reply-To: <1321695125-2237-1-git-send-email-xiaoqiangnk@gmail.com>
On Sat, Nov 19, 2011 at 05:32:05PM +0800, Yongqiang Yang wrote:
> Currently, we clear revoked flag only when a block is reused. However,
> this can tigger a false journal error. Consider a situation when a block
> is used as a meta block and is deleted(revoked) in ordered mode, then the
> block is allocated as a data block to a file. At this moment, user changes
> the file's journal mode from ordered to journaled and truncates the file.
> The block will be considered re-revoked by journal because it has revoked
> flag still pending from the last transaction and an assertion triggers.
>
> We fix the problem by keeping the revoked status more uptodate - we clear
> revoked flag when switching revoke tables to reflect there is no revoked
> buffers in current transaction any more.
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Oops, I replied the wrong message. This is the version of the patch
which I applied...
- Ted
prev parent reply other threads:[~2011-12-28 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 9:32 [PATCH v2] jbd2: clear revoked flag on buffers before a new transaction started Yongqiang Yang
2011-12-28 23:31 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228233102.GF12370@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).