From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH V6 RESEND 13/15] ext4: add new online resize interface
Date: Wed, 4 Jan 2012 00:03:33 -0500 [thread overview]
Message-ID: <20120104050333.GA13438@thunk.org> (raw)
In-Reply-To: <1325242812-27005-14-git-send-email-xiaoqiangnk@gmail.com>
On Fri, Dec 30, 2011 at 07:00:10PM +0800, Yongqiang Yang wrote:
> + if (EXT4_HAS_RO_COMPAT_FEATURE(sb,
> + EXT4_FEATURE_RO_COMPAT_BIGALLOC)) {
> + ext4_msg(sb, KERN_ERR,
> + "Online resizing not supported with bigalloc");
> + return -EOPNOTSUPP;
> + }
I've also added checks to disable on-line resizing if the meta_bg file
system feature is set, since the on-line resizing code in this patch
series does not support the meta_bg block group descriptor layout
(which is required for file systems > 32-bits).
In addition, I've added a check so that if the requested number of
blocks is greater than 2**32-1, and the 64-bit option is not set, to
bail out with an error.
In theory the resize2fs userspace code will be doing these checks, but
(a) at some point in the future the meta_bg support will be added, and
so if the kernel doesn't support meta_bg, it needs to fail, and not
depend on userspace to do this check. Also (b) we want to make sure
this code doesn't do something crazy in case someone calls the ioctl
directly.
- Ted
next prev parent reply other threads:[~2012-01-04 5:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 10:59 [PATCH V6 RESEND] ext4: add new online resize Yongqiang Yang
2011-12-30 10:59 ` [PATCH V6 RESEND 01/15] ext4: add a function which extends a group without checking parameters Yongqiang Yang
2012-01-03 21:07 ` Ted Ts'o
2012-01-04 3:59 ` Yongqiang Yang
2011-12-30 10:59 ` [PATCH V6 RESEND 02/15] ext4: add a function which adds a new desc to a fs Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 03/15] ext4: add a function which sets up a new group desc Yongqiang Yang
2012-01-04 2:24 ` Ted Ts'o
2012-01-04 4:02 ` Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 04/15] ext4: add a function which updates super block Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 05/15] ext4: add a structure which will be used by 64bit-resize interface Yongqiang Yang
2012-01-04 2:30 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 06/15] ext4: add a function which sets up group blocks of a flex groups Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 07/15] ext4: add a function which adds several group descriptors Yongqiang Yang
2012-01-04 2:44 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 08/15] ext4: add a function which sets up a flex groups each time Yongqiang Yang
2012-01-04 2:46 ` Ted Ts'o
2011-12-30 11:00 ` [PATCH V6 RESEND 09/15] ext4: enable ext4_update_super() to handle a flex groups Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 10/15] ext4: pass verify_reserved_gdb() the number of group decriptors Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 11/15] ext4: add a new function which allocates bitmaps and inode tables Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 12/15] ext4: add a new function which adds a flex group to a fs Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 13/15] ext4: add new online resize interface Yongqiang Yang
2012-01-04 5:03 ` Ted Ts'o [this message]
2011-12-30 11:00 ` [PATCH V6 RESEND 14/15] ext4: let ext4_group_extend() use common code Yongqiang Yang
2011-12-30 11:00 ` [PATCH V6 RESEND 15/15] ext4: let ext4_group_add() " Yongqiang Yang
2011-12-31 17:40 ` [PATCH V6 RESEND] ext4: add new online resize Andreas Dilger
2012-01-03 20:50 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104050333.GA13438@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).