From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Andreas Dilger <adilger.kernel@dilger.ca>,
Theodore Tso <tytso@mit.edu>,
"Darrick J. Wong" <djwong@us.ibm.com>
Cc: Sunil Mushran <sunil.mushran@oracle.com>,
Amir Goldstein <amir73il@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Mingming Cao <cmm@us.ibm.com>,
Joel Becker <jlbec@evilplan.org>,
linux-ext4@vger.kernel.org, Coly Li <colyli@gmail.com>
Subject: [PATCH 47/51] e2fsck: Check commit block checksum during recovery
Date: Sat, 07 Jan 2012 00:37:56 -0800 [thread overview]
Message-ID: <20120107083756.25788.26866.stgit@elm3c44.beaverton.ibm.com> (raw)
In-Reply-To: <20120107083256.25788.41238.stgit@elm3c44.beaverton.ibm.com>
When recovering a journal with checksum v2, verify the commit block checksum.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
e2fsck/recovery.c | 33 +++++++++++++++++++++++++++++++++
1 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/e2fsck/recovery.c b/e2fsck/recovery.c
index f76e7d8..8f55411 100644
--- a/e2fsck/recovery.c
+++ b/e2fsck/recovery.c
@@ -375,6 +375,26 @@ static int calc_chksums(journal_t *journal, struct buffer_head *bh,
return 0;
}
+static int jbd2_commit_block_csum_verify(journal_t *j, void *buf)
+{
+ struct commit_header *h;
+ __u32 provided, calculated;
+
+ if (!JFS_HAS_INCOMPAT_FEATURE(j, JFS_FEATURE_INCOMPAT_CSUM_V2))
+ return 1;
+
+ h = buf;
+ provided = h->h_chksum[0];
+ h->h_chksum[0] = 0;
+ calculated = ext2fs_crc32c_le(~0, j->j_superblock->s_uuid,
+ sizeof(j->j_superblock->s_uuid));
+ calculated = ext2fs_crc32c_le(calculated, buf, j->j_blocksize);
+ h->h_chksum[0] = provided;
+
+ provided = ext2fs_be32_to_cpu(provided);
+ return provided == calculated;
+}
+
static int do_one_pass(journal_t *journal,
struct recovery_info *info, enum passtype pass)
{
@@ -696,6 +716,19 @@ static int do_one_pass(journal_t *journal,
}
crc32_sum = ~0;
}
+ if (pass == PASS_SCAN &&
+ !jbd2_commit_block_csum_verify(journal,
+ bh->b_data)) {
+ info->end_transaction = next_commit_ID;
+
+ if (!JFS_HAS_INCOMPAT_FEATURE(journal,
+ JFS_FEATURE_INCOMPAT_ASYNC_COMMIT)) {
+ journal->j_failed_commit =
+ next_commit_ID;
+ brelse(bh);
+ break;
+ }
+ }
brelse(bh);
next_commit_ID++;
continue;
next prev parent reply other threads:[~2012-01-07 8:38 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 8:32 [PATCH v2.3 00/51] e2fsprogs: Add metadata checksumming Darrick J. Wong
2012-01-07 8:33 ` [PATCH 01/51] libext2fs: Read and write full size inodes Darrick J. Wong
2012-01-07 8:33 ` [PATCH 02/51] libext2fs: Change ext4 on-disk layout to support metadata checksumming Darrick J. Wong
2012-01-07 8:33 ` [PATCH 03/51] debugfs: Optionally ignore bad checksums Darrick J. Wong
2012-01-07 8:33 ` [PATCH 04/51] libext2fs: Precompute FS UUID checksum seed Darrick J. Wong
2012-01-07 8:33 ` [PATCH 05/51] libext2fs: Add inode checksum support Darrick J. Wong
2012-01-07 8:33 ` [PATCH 06/51] debugfs: Dump inode checksum when appropriate Darrick J. Wong
2012-01-07 8:33 ` [PATCH 07/51] tune2fs: Add inode checksum support Darrick J. Wong
2012-01-07 8:33 ` [PATCH 08/51] e2fsck: Verify and correct inode checksums Darrick J. Wong
2012-01-07 8:33 ` [PATCH 09/51] mke2fs: Allow metadata checksums to be turned on at mkfs time Darrick J. Wong
2012-01-07 8:34 ` [PATCH 10/51] libext2fs: Create the inode bitmap checksum Darrick J. Wong
2012-01-07 8:34 ` [PATCH 11/51] tune2fs: Rewrite inode bitmap checksums Darrick J. Wong
2012-01-07 8:34 ` [PATCH 12/51] dumpe2fs: Display inode bitmap checksum Darrick J. Wong
2012-01-07 8:34 ` [PATCH 13/51] e2fsck: Verify " Darrick J. Wong
2012-01-07 8:34 ` [PATCH 14/51] libext2fs: Create the block " Darrick J. Wong
2012-01-07 8:34 ` [PATCH 15/51] dumpe2fs: Display " Darrick J. Wong
2012-01-07 8:34 ` [PATCH 16/51] e2fsck: Verify " Darrick J. Wong
2012-01-07 8:34 ` [PATCH 17/51] e2fsck: Don't verify bitmap checksums Darrick J. Wong
2012-01-07 8:34 ` [PATCH 18/51] tune2fs: Rewrite block " Darrick J. Wong
2012-01-07 8:34 ` [PATCH 19/51] libext2fs: Verify and calculate extent tree block checksums Darrick J. Wong
2012-01-07 8:35 ` [PATCH 20/51] tune2fs: Enable extent tree checksums Darrick J. Wong
2012-01-07 8:35 ` [PATCH 21/51] e2fsck: Verify extent tree blocks and clear the bad ones Darrick J. Wong
2012-01-07 8:35 ` [PATCH 22/51] debugfs: Print htree internal node checksums Darrick J. Wong
2012-01-07 8:35 ` [PATCH 23/51] libext2fs: Add dx_root/dx_node checksum calculation and verification helpers Darrick J. Wong
2012-01-07 8:35 ` [PATCH 24/51] e2fsck: Verify htree root/node checksums Darrick J. Wong
2012-01-07 8:35 ` [PATCH 25/51] libext2fs: Introduce dir_entry_tail to provide checksums for directory leaf nodes Darrick J. Wong
2012-01-07 8:35 ` [PATCH 26/51] e2fsck: Check directory leaf block checksums Darrick J. Wong
2012-01-07 8:35 ` [PATCH 27/51] tune2fs: Rebuild and checksum directories when toggling metadata_csum or changing UUID Darrick J. Wong
2012-01-07 8:35 ` [PATCH 28/51] libext2fs: Verify and calculate extended attribute block checksums Darrick J. Wong
2012-01-07 8:36 ` [PATCH 29/51] e2fsck: Check " Darrick J. Wong
2012-01-07 8:36 ` [PATCH 30/51] tune2fs: Rewrite " Darrick J. Wong
2012-01-07 8:36 ` [PATCH 31/51] libext2fs: Calculate and verify superblock checksums Darrick J. Wong
2012-01-07 8:36 ` [PATCH 32/51] e2fsck: Handle superblock checksum errors gracefully Darrick J. Wong
2012-01-07 8:36 ` [PATCH 33/51] libext2fs: Record the checksum algorithm in use in the superblock Darrick J. Wong
2012-01-07 8:36 ` [PATCH 34/51] tune2fs: Store checksum algorithm type in superblock Darrick J. Wong
2012-01-07 8:36 ` [PATCH 35/51] mke2fs: Record the checksum algorithm in use in the superblock Darrick J. Wong
2012-01-07 8:36 ` [PATCH 36/51] libext2fs: Block group checksum should use metadata_csum algorithm (if feature flag set) Darrick J. Wong
2012-01-07 8:36 ` [PATCH 37/51] tune2fs: Rewrite block group checksums when changing bg_use_meta_csum feature Darrick J. Wong
2012-01-07 8:36 ` [PATCH 38/51] mke2fs: Warn if not enabling all the features that metadata_csum wants Darrick J. Wong
2012-01-07 8:37 ` [PATCH 39/51] libext2fs: Add checksum to MMP block Darrick J. Wong
2012-01-07 8:37 ` [PATCH 40/51] e2fsck: Verify and correct MMP checksum problems Darrick J. Wong
2012-01-07 8:37 ` [PATCH 41/51] tune2fs: Force MMP update when changing metadata_csum flag Darrick J. Wong
2012-01-07 8:37 ` [PATCH 42/51] libext2fs: Change on-disk journal layout to support metadata checksumming Darrick J. Wong
2012-01-07 8:37 ` [PATCH 43/51] libext2fs: Dump feature flags for jbd2 v2 checksums Darrick J. Wong
2012-01-07 8:37 ` [PATCH 44/51] e2fsck: Check journal superblock checksum prior to recovery Darrick J. Wong
2012-01-07 8:37 ` [PATCH 45/51] e2fsck: Check revoke block checksum during recovery Darrick J. Wong
2012-01-07 8:37 ` [PATCH 46/51] e2fsck: Check descriptor block checksum when recovering journal Darrick J. Wong
2012-01-07 8:37 ` Darrick J. Wong [this message]
2012-01-07 8:38 ` [PATCH 48/51] e2fsck: Verify data block checksums " Darrick J. Wong
2012-01-07 8:38 ` [PATCH 49/51] libext2fs: Enable support for the metadata checksumming feature Darrick J. Wong
2012-01-07 8:38 ` [PATCH 50/51] libext2fs: Bring the CRC32c implementation up to date with the kernel implementation Darrick J. Wong
2012-01-07 8:38 ` [PATCH 51/51] e2fsck: Refactor crc32_be code Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2011-12-14 1:13 [PATCH v2.2 00/51] e2fsprogs: Add metadata checksumming Darrick J. Wong
2011-12-14 1:18 ` [PATCH 47/51] e2fsck: Check commit block checksum during recovery Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107083756.25788.26866.stgit@elm3c44.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=andi@firstfloor.org \
--cc=cmm@us.ibm.com \
--cc=colyli@gmail.com \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sunil.mushran@oracle.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).