Re: [PATCH] ext4: setattr: Forbid setting data journalling when delalloc enabled

Ted Ts'o
2012-01-09T15:55:06Z

On Mon, Jan 09, 2012 at 04:45:03PM +0100, Lukas Czerner wrote:
> Ext4 does not support data journalling with delayed allocation enabled.
> We even does not allow to mount the file system with delayed allocation
> and data journalling enabled, but it can be set via FS_IOC_SETFLAGS
> which is wrong.
>
> When data journalling and delayed allocation is enabled it can lead to
> troubles. Here is one example how to reproduce an oops:
>
> mkfs.ext4 /dev/sdd
> mount /dev/sdd /mnt/test1
> dd if=/dev/zero of=/mnt/test1/file bs=1M count=4
> chattr +j /mnt/test1/file
> dd if=/dev/zero of=/mnt/test1/file bs=1M count=4 conv=notrunc
> chattr -j /mnt/test1/file
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Don't we also need to add a check in ext4_should_journal_data() in
fs/ext4/ext4_jbd2.h? Otherwise we could get in trouble if the data
journalling flag had been set previously when the file system was
mounted nodelalloc.

In fact it could be argued that we don't need to return EOPNOSUPP, or
printk a message, but simply make sure that the data journal flag is
ignored in if delayed allocation is enabled. If that's true, we can
allow the user to set or clear the journal flag as much as they like;
it would just be ignored.

Thanks,

- Ted