From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
Josh Boyer <jwboyer@redhat.com>,
linux-ext4@vger.kernel.org, kernel-team@fedoraproject.org
Subject: Re: [PATCH] ext4: Support "check=none" "nocheck" mount options
Date: Wed, 11 Jan 2012 10:26:46 -0500 [thread overview]
Message-ID: <20120111152646.GB4589@thunk.org> (raw)
In-Reply-To: <4F0DA724.2040506@redhat.com>
On Wed, Jan 11, 2012 at 09:13:40AM -0600, Eric Sandeen wrote:
> > In any case, I can't imagine why a user would have this set for a kernel
> > option that might have last been valid 10 years ago, and why the 5 users
> > in the world that might have this set cannot simply remove it from their
> > fstab, since it does absolutely nothing?
>
> Well, I agree that it should be deprecated, but that's a separate issue from
> making ext4 handle all current ext2/3 mount options.
>
> Let's just push this one in, and can do another patch to add the dire
> deprecation warnings to all filesystems, ok? Then in 5 more years we can
> remember to remove it ;)
If we're going to deprecate it, we should deprecate it for *all* of
the ext 2/3/4 file systems. Otherwise let's not bother, and keep the
no-op for backwards compatibility. If we are going to support ext4
taking over for ext2/3, then yes we need to support any common mount
options, and if we want to deprecate a particular option in ext4, we
should try to deprecate them in ext2/3 as well.
- Ted
next prev parent reply other threads:[~2012-01-11 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 17:41 [PATCH] ext4: Support "check=none" "nocheck" mount options Josh Boyer
2012-01-10 17:43 ` Eric Sandeen
2012-01-11 10:07 ` Andreas Dilger
2012-01-11 14:50 ` Josh Boyer
2012-01-11 21:07 ` Andreas Dilger
2012-01-11 15:13 ` Eric Sandeen
2012-01-11 15:26 ` Ted Ts'o [this message]
2012-01-11 15:35 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111152646.GB4589@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=jwboyer@redhat.com \
--cc=kernel-team@fedoraproject.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).